Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 14081010: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some gtk issues Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/device_orientation/provider_impl.cc ('k') | content/browser/devtools/devtools_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index 237e6b9893f7016957e95af4586b1e5e86e2cb3c..d5d94533835c533c301ae8ae4ec90746b3794869 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -192,7 +192,7 @@ DevToolsHttpHandlerImpl::~DevToolsHttpHandlerImpl() {
}
void DevToolsHttpHandlerImpl::Start() {
- if (thread_.get())
+ if (thread_)
return;
thread_.reset(new base::Thread(kDevToolsHandlerThreadName));
BrowserThread::PostTask(
@@ -226,7 +226,7 @@ void DevToolsHttpHandlerImpl::ResetHandlerThreadAndRelease() {
}
void DevToolsHttpHandlerImpl::Stop() {
- if (!thread_.get())
+ if (!thread_)
return;
BrowserThread::PostTaskAndReply(
BrowserThread::FILE, FROM_HERE,
@@ -606,7 +606,7 @@ void DevToolsHttpHandlerImpl::OnDiscoveryPageRequestUI(int connection_id) {
void DevToolsHttpHandlerImpl::OnWebSocketRequestUI(
int connection_id,
const net::HttpServerRequestInfo& request) {
- if (!thread_.get())
+ if (!thread_)
return;
std::string browser_prefix = "/devtools/browser";
size_t browser_pos = request.path.find(browser_prefix);
@@ -739,7 +739,7 @@ void DevToolsHttpHandlerImpl::SendJson(int connection_id,
net::HttpStatusCode status_code,
base::Value* value,
const std::string& message) {
- if (!thread_.get())
+ if (!thread_)
return;
// Serialize value and message.
@@ -771,7 +771,7 @@ void DevToolsHttpHandlerImpl::SendJson(int connection_id,
void DevToolsHttpHandlerImpl::Send200(int connection_id,
const std::string& data,
const std::string& mime_type) {
- if (!thread_.get())
+ if (!thread_)
return;
thread_->message_loop()->PostTask(
FROM_HERE,
@@ -783,7 +783,7 @@ void DevToolsHttpHandlerImpl::Send200(int connection_id,
}
void DevToolsHttpHandlerImpl::Send404(int connection_id) {
- if (!thread_.get())
+ if (!thread_)
return;
thread_->message_loop()->PostTask(
FROM_HERE,
@@ -792,7 +792,7 @@ void DevToolsHttpHandlerImpl::Send404(int connection_id) {
void DevToolsHttpHandlerImpl::Send500(int connection_id,
const std::string& message) {
- if (!thread_.get())
+ if (!thread_)
return;
thread_->message_loop()->PostTask(
FROM_HERE,
@@ -803,7 +803,7 @@ void DevToolsHttpHandlerImpl::Send500(int connection_id,
void DevToolsHttpHandlerImpl::AcceptWebSocket(
int connection_id,
const net::HttpServerRequestInfo& request) {
- if (!thread_.get())
+ if (!thread_)
return;
thread_->message_loop()->PostTask(
FROM_HERE,
« no previous file with comments | « content/browser/device_orientation/provider_impl.cc ('k') | content/browser/devtools/devtools_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698