Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Side by Side Diff: content/renderer/browser_plugin/mock_browser_plugin_manager.cc

Issue 14081010: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some gtk issues Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/browser_plugin/mock_browser_plugin_manager.h" 5 #include "content/renderer/browser_plugin/mock_browser_plugin_manager.h"
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "content/common/browser_plugin/browser_plugin_messages.h" 8 #include "content/common/browser_plugin/browser_plugin_messages.h"
9 #include "content/renderer/browser_plugin/mock_browser_plugin.h" 9 #include "content/renderer/browser_plugin/mock_browser_plugin.h"
10 #include "ipc/ipc_message.h" 10 #include "ipc/ipc_message.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 int instance_id) { 43 int instance_id) {
44 browser_plugin->SetInstanceID(instance_id, true); 44 browser_plugin->SetInstanceID(instance_id, true);
45 } 45 }
46 46
47 bool MockBrowserPluginManager::Send(IPC::Message* msg) { 47 bool MockBrowserPluginManager::Send(IPC::Message* msg) {
48 // This is a copy-and-paste from MockRenderThread::Send. 48 // This is a copy-and-paste from MockRenderThread::Send.
49 // We need to simulate a synchronous channel, thus we are going to receive 49 // We need to simulate a synchronous channel, thus we are going to receive
50 // through this function messages, messages with reply and reply messages. 50 // through this function messages, messages with reply and reply messages.
51 // We can only handle one synchronous message at a time. 51 // We can only handle one synchronous message at a time.
52 if (msg->is_reply()) { 52 if (msg->is_reply()) {
53 if (reply_deserializer_.get()) { 53 if (reply_deserializer_) {
54 reply_deserializer_->SerializeOutputParameters(*msg); 54 reply_deserializer_->SerializeOutputParameters(*msg);
55 reply_deserializer_.reset(); 55 reply_deserializer_.reset();
56 } 56 }
57 } else { 57 } else {
58 if (msg->is_sync()) { 58 if (msg->is_sync()) {
59 // We actually need to handle deleting the reply deserializer for sync 59 // We actually need to handle deleting the reply deserializer for sync
60 // messages. 60 // messages.
61 reply_deserializer_.reset( 61 reply_deserializer_.reset(
62 static_cast<IPC::SyncMessage*>(msg)->GetReplyDeserializer()); 62 static_cast<IPC::SyncMessage*>(msg)->GetReplyDeserializer());
63 } 63 }
64 OnMessageReceived(*msg); 64 OnMessageReceived(*msg);
65 } 65 }
66 delete msg; 66 delete msg;
67 return true; 67 return true;
68 } 68 }
69 69
70 bool MockBrowserPluginManager::OnMessageReceived( 70 bool MockBrowserPluginManager::OnMessageReceived(
71 const IPC::Message& message) { 71 const IPC::Message& message) {
72 // Save the message in the sink. 72 // Save the message in the sink.
73 sink_.OnMessageReceived(message); 73 sink_.OnMessageReceived(message);
74 return false; 74 return false;
75 } 75 }
76 76
77 } // namespace content 77 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | content/renderer/gpu/stream_texture_host_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698