Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: content/shell/shell_javascript_dialog_manager.cc

Issue 14081010: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some gtk issues Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/shell_gtk.cc ('k') | content/shell/shell_url_request_context_getter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/shell_javascript_dialog_manager.cc
diff --git a/content/shell/shell_javascript_dialog_manager.cc b/content/shell/shell_javascript_dialog_manager.cc
index 17f5b6bb61faea0557466b298048af175c3cb0dd..4ef5e2b372e41e0948f36d95e10b7a83bd11678f 100644
--- a/content/shell/shell_javascript_dialog_manager.cc
+++ b/content/shell/shell_javascript_dialog_manager.cc
@@ -46,7 +46,7 @@ void ShellJavaScriptDialogManager::RunJavaScriptDialog(
#if defined(OS_MACOSX) || defined(OS_WIN) || defined(TOOLKIT_GTK)
*did_suppress_message = false;
- if (dialog_.get()) {
+ if (dialog_) {
// One dialog at a time, please.
*did_suppress_message = true;
return;
@@ -89,7 +89,7 @@ void ShellJavaScriptDialogManager::RunBeforeUnloadDialog(
}
#if defined(OS_MACOSX) || defined(OS_WIN) || defined(TOOLKIT_GTK)
- if (dialog_.get()) {
+ if (dialog_) {
// Seriously!?
callback.Run(true, string16());
return;
@@ -118,7 +118,7 @@ void ShellJavaScriptDialogManager::RunBeforeUnloadDialog(
void ShellJavaScriptDialogManager::ResetJavaScriptState(
WebContents* web_contents) {
#if defined(OS_MACOSX) || defined(OS_WIN) || defined(TOOLKIT_GTK)
- if (dialog_.get()) {
+ if (dialog_) {
dialog_->Cancel();
dialog_.reset();
}
« no previous file with comments | « content/shell/shell_gtk.cc ('k') | content/shell/shell_url_request_context_getter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698