Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: content/browser/download/download_item_impl.cc

Issue 14081010: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some gtk issues Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/base_file.cc ('k') | content/browser/download/download_resource_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_item_impl.cc
diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc
index cbac17b29a3c935396e0c9e2253f7776caa5f990..7d5dd105282efdf3b9cffd659b72228638ddf8e6 100644
--- a/content/browser/download/download_item_impl.cc
+++ b/content/browser/download/download_item_impl.cc
@@ -347,7 +347,7 @@ void DownloadItemImpl::Cancel(bool user_cancel) {
// |SavePackage| integration.
// |download_file_| can be NULL if Interrupt() is called after the
// download file has been released.
- if (!is_save_package_download_ && download_file_.get())
+ if (!is_save_package_download_ && download_file_)
ReleaseDownloadFile(true);
if (state_ != INTERRUPTED_INTERNAL) {
@@ -688,7 +688,7 @@ WebContents* DownloadItemImpl::GetWebContents() const {
// paths that might be used by DownloadItems created from history import.
// Currently such items have null request_handle_s, where other items
// (regular and SavePackage downloads) have actual objects off the pointer.
- if (request_handle_.get())
+ if (request_handle_)
return request_handle_->GetWebContents();
return NULL;
}
@@ -1452,7 +1452,7 @@ void DownloadItemImpl::ReleaseDownloadFile(bool destroy_file) {
// |SavePackage| integration.
// |download_file_| can be NULL if Interrupt() is called after the
// download file has been released.
- if (!is_save_package_download_ && download_file_.get()) {
+ if (!is_save_package_download_ && download_file_) {
BrowserThread::PostTask(
BrowserThread::FILE, FROM_HERE,
// Will be deleted at end of task execution.
« no previous file with comments | « content/browser/download/base_file.cc ('k') | content/browser/download/download_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698