Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: content/renderer/media/pepper_platform_video_decoder_impl.cc

Issue 14081010: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some gtk issues Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/pepper_platform_video_decoder_impl.h" 5 #include "content/renderer/media/pepper_platform_video_decoder_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "content/common/child_process.h" 9 #include "content/common/child_process.h"
10 #include "content/common/gpu/client/gpu_channel_host.h" 10 #include "content/common/gpu/client/gpu_channel_host.h"
11 #include "content/renderer/render_thread_impl.h" 11 #include "content/renderer/render_thread_impl.h"
12 12
13 using media::BitstreamBuffer; 13 using media::BitstreamBuffer;
14 14
15 namespace content { 15 namespace content {
16 16
17 PlatformVideoDecoderImpl::PlatformVideoDecoderImpl( 17 PlatformVideoDecoderImpl::PlatformVideoDecoderImpl(
18 VideoDecodeAccelerator::Client* client, 18 VideoDecodeAccelerator::Client* client,
19 int32 command_buffer_route_id) 19 int32 command_buffer_route_id)
20 : client_(client), 20 : client_(client),
21 command_buffer_route_id_(command_buffer_route_id) { 21 command_buffer_route_id_(command_buffer_route_id) {
22 DCHECK(client); 22 DCHECK(client);
23 } 23 }
24 24
25 PlatformVideoDecoderImpl::~PlatformVideoDecoderImpl() {} 25 PlatformVideoDecoderImpl::~PlatformVideoDecoderImpl() {}
26 26
27 bool PlatformVideoDecoderImpl::Initialize(media::VideoCodecProfile profile) { 27 bool PlatformVideoDecoderImpl::Initialize(media::VideoCodecProfile profile) {
28 // TODO(vrk): Support multiple decoders. 28 // TODO(vrk): Support multiple decoders.
29 if (decoder_.get()) 29 if (decoder_)
30 return true; 30 return true;
31 31
32 RenderThreadImpl* render_thread = RenderThreadImpl::current(); 32 RenderThreadImpl* render_thread = RenderThreadImpl::current();
33 33
34 // This is not synchronous, but subsequent IPC messages will be buffered, so 34 // This is not synchronous, but subsequent IPC messages will be buffered, so
35 // it is okay to immediately send IPC messages through the returned channel. 35 // it is okay to immediately send IPC messages through the returned channel.
36 GpuChannelHost* channel = 36 GpuChannelHost* channel =
37 render_thread->EstablishGpuChannelSync( 37 render_thread->EstablishGpuChannelSync(
38 CAUSE_FOR_GPU_LAUNCH_VIDEODECODEACCELERATOR_INITIALIZE); 38 CAUSE_FOR_GPU_LAUNCH_VIDEODECODEACCELERATOR_INITIALIZE);
39 39
(...skipping 29 matching lines...) Expand all
69 DCHECK(decoder_.get()); 69 DCHECK(decoder_.get());
70 decoder_->Flush(); 70 decoder_->Flush();
71 } 71 }
72 72
73 void PlatformVideoDecoderImpl::Reset() { 73 void PlatformVideoDecoderImpl::Reset() {
74 DCHECK(decoder_.get()); 74 DCHECK(decoder_.get());
75 decoder_->Reset(); 75 decoder_->Reset();
76 } 76 }
77 77
78 void PlatformVideoDecoderImpl::Destroy() { 78 void PlatformVideoDecoderImpl::Destroy() {
79 if (decoder_.get()) 79 if (decoder_)
80 decoder_.release()->Destroy(); 80 decoder_.release()->Destroy();
81 client_ = NULL; 81 client_ = NULL;
82 delete this; 82 delete this;
83 } 83 }
84 84
85 void PlatformVideoDecoderImpl::NotifyError( 85 void PlatformVideoDecoderImpl::NotifyError(
86 VideoDecodeAccelerator::Error error) { 86 VideoDecodeAccelerator::Error error) {
87 DCHECK(RenderThreadImpl::current()); 87 DCHECK(RenderThreadImpl::current());
88 client_->NotifyError(error); 88 client_->NotifyError(error);
89 } 89 }
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 DCHECK(RenderThreadImpl::current()); 121 DCHECK(RenderThreadImpl::current());
122 client_->NotifyFlushDone(); 122 client_->NotifyFlushDone();
123 } 123 }
124 124
125 void PlatformVideoDecoderImpl::NotifyResetDone() { 125 void PlatformVideoDecoderImpl::NotifyResetDone() {
126 DCHECK(RenderThreadImpl::current()); 126 DCHECK(RenderThreadImpl::current());
127 client_->NotifyResetDone(); 127 client_->NotifyResetDone();
128 } 128 }
129 129
130 } // namespace content 130 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/peer_connection_tracker.cc ('k') | content/renderer/media/rtc_peer_connection_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698