Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: content/browser/gamepad/gamepad_provider.cc

Issue 14081010: Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some gtk issues Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <cmath> 5 #include <cmath>
6 #include <set> 6 #include <set>
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 base::Bind(&GamepadProvider::DoInitializePollingThread, 121 base::Bind(&GamepadProvider::DoInitializePollingThread,
122 base::Unretained(this), 122 base::Unretained(this),
123 base::Passed(&fetcher))); 123 base::Passed(&fetcher)));
124 } 124 }
125 125
126 void GamepadProvider::DoInitializePollingThread( 126 void GamepadProvider::DoInitializePollingThread(
127 scoped_ptr<GamepadDataFetcher> fetcher) { 127 scoped_ptr<GamepadDataFetcher> fetcher) {
128 DCHECK(MessageLoop::current() == polling_thread_->message_loop()); 128 DCHECK(MessageLoop::current() == polling_thread_->message_loop());
129 DCHECK(!data_fetcher_.get()); // Should only initialize once. 129 DCHECK(!data_fetcher_.get()); // Should only initialize once.
130 130
131 if (!fetcher.get()) 131 if (!fetcher)
132 fetcher.reset(new GamepadPlatformDataFetcher); 132 fetcher.reset(new GamepadPlatformDataFetcher);
133 data_fetcher_ = fetcher.Pass(); 133 data_fetcher_ = fetcher.Pass();
134 } 134 }
135 135
136 void GamepadProvider::SendPauseHint(bool paused) { 136 void GamepadProvider::SendPauseHint(bool paused) {
137 DCHECK(MessageLoop::current() == polling_thread_->message_loop()); 137 DCHECK(MessageLoop::current() == polling_thread_->message_loop());
138 if (data_fetcher_.get()) 138 if (data_fetcher_)
139 data_fetcher_->PauseHint(paused); 139 data_fetcher_->PauseHint(paused);
140 } 140 }
141 141
142 void GamepadProvider::DoPoll() { 142 void GamepadProvider::DoPoll() {
143 DCHECK(MessageLoop::current() == polling_thread_->message_loop()); 143 DCHECK(MessageLoop::current() == polling_thread_->message_loop());
144 DCHECK(have_scheduled_do_poll_); 144 DCHECK(have_scheduled_do_poll_);
145 have_scheduled_do_poll_ = false; 145 have_scheduled_do_poll_ = false;
146 146
147 bool changed; 147 bool changed;
148 GamepadHardwareBuffer* hwbuf = SharedMemoryAsHardwareBuffer(); 148 GamepadHardwareBuffer* hwbuf = SharedMemoryAsHardwareBuffer();
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 if (GamepadsHaveUserGesture(SharedMemoryAsHardwareBuffer()->buffer)) { 202 if (GamepadsHaveUserGesture(SharedMemoryAsHardwareBuffer()->buffer)) {
203 for (size_t i = 0; i < user_gesture_observers_.size(); i++) { 203 for (size_t i = 0; i < user_gesture_observers_.size(); i++) {
204 user_gesture_observers_[i].message_loop->PostTask(FROM_HERE, 204 user_gesture_observers_[i].message_loop->PostTask(FROM_HERE,
205 user_gesture_observers_[i].closure); 205 user_gesture_observers_[i].closure);
206 } 206 }
207 user_gesture_observers_.clear(); 207 user_gesture_observers_.clear();
208 } 208 }
209 } 209 }
210 210
211 } // namespace content 211 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/fileapi/fileapi_message_filter.cc ('k') | content/browser/gamepad/gamepad_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698