Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1403373012: Make appending default precision be controled by GLSL (Closed)

Created:
5 years, 2 months ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make appending default precision be controled by GLSL BUG=skia: Committed: https://skia.googlesource.com/skia/+/cb7ba1eafce89a2f90239a7be56050fa98a47b9f

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : remove unused variable #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -63 lines) Patch
M bench/GLInstancedArraysBench.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M bench/GLVec4ScalarBench.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M bench/GLVertexAttributesBench.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSL.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSL.cpp View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
egdaniel
Another small part of separating glsl from gl code
5 years, 2 months ago (2015-10-22 19:21:01 UTC) #2
ethannicholas
lgtm
5 years, 2 months ago (2015-10-23 13:23:46 UTC) #3
jvanverth1
On 2015/10/23 13:23:46, ethannicholas wrote: > lgtm lgtm 2
5 years, 2 months ago (2015-10-23 20:34:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403373012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403373012/20001
5 years, 2 months ago (2015-10-23 20:34:57 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/3870)
5 years, 2 months ago (2015-10-23 20:35:57 UTC) #8
jvanverth1
https://codereview.chromium.org/1403373012/diff/20001/src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp File src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp (right): https://codereview.chromium.org/1403373012/diff/20001/src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp#newcode270 src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp:270: GrGLGpu* gpu = fProgramBuilder->gpu(); (from the dry run) This ...
5 years, 2 months ago (2015-10-23 20:39:22 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403373012/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403373012/40001
5 years, 1 month ago (2015-10-26 14:40:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403373012/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403373012/60001
5 years, 1 month ago (2015-10-26 15:27:28 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 15:38:28 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/cb7ba1eafce89a2f90239a7be56050fa98a47b9f

Powered by Google App Engine
This is Rietveld 408576698