Extract DiagnosticReporter implementation from Compiler.

Extract DiagnosticReporter implementation from Compiler.

BUG=
R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/76b7203c198dbfbd34dc57829fdbc7d687143c2c

[Johnni Winther, 2015-10-02 13:13:15]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[Johnni Winther, 2015-10-02 13:13:16]

Main changes in compiler.dart and apiimpl.dart

[sigurdm, 2015-10-05 13:45:34]

LGTM

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:1775: SourceSpan spanFromSpannable(Spannable
node) {
Why is this not a method on `Spannable`?

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/dart_b...
File pkg/compiler/lib/src/dart_backend/outputter.dart (right):

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/dart_b...
pkg/compiler/lib/src/dart_backend/outputter.dart:21: final DiagnosticReporter
listener;
Rename variable? (several occurences in this file)

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/diagno...
File pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart (right):

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/diagno...
pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart:1: // Copyright (c)
2012, the Dart project authors.  Please see the AUTHORS file
You should rename this file.

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:541: DiagnosticReporter listener) {
Rename variable

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:735: void addMember(Element element,
DiagnosticReporter listener) {
Rename variable?

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:840: DiagnosticReporter listener) {
Rename variable? (more occurrences in this file)

[Johnni Winther, 2015-10-06 08:04:33]

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:1775: SourceSpan spanFromSpannable(Spannable
node) {
On 2015/10/05 13:45:34, sigurdm wrote:
> Why is this not a method on `Spannable`?

Because Spannable is only a tagging interface.

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/dart_b...
File pkg/compiler/lib/src/dart_backend/outputter.dart (right):

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/dart_b...
pkg/compiler/lib/src/dart_backend/outputter.dart:21: final DiagnosticReporter
listener;
On 2015/10/05 13:45:34, sigurdm wrote:
> Rename variable? (several occurences in this file)

Done.

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/diagno...
File pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart (right):

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/diagno...
pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart:1: // Copyright (c)
2012, the Dart project authors.  Please see the AUTHORS file
On 2015/10/05 13:45:34, sigurdm wrote:
> You should rename this file.

Will do together with the cleanup of the interface, cf. the TODO below.

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:541: DiagnosticReporter listener) {
On 2015/10/05 13:45:34, sigurdm wrote:
> Rename variable

Done.

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:735: void addMember(Element element,
DiagnosticReporter listener) {
On 2015/10/05 13:45:34, sigurdm wrote:
> Rename variable?

Done.

https://codereview.chromium.org/1383483006/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:840: DiagnosticReporter listener) {
On 2015/10/05 13:45:34, sigurdm wrote:
> Rename variable? (more occurrences in this file)

Done.

[Johnni Winther, 2015-10-06 08:25:00]

Committed patchset #4 (id:60001) manually as
76b7203c198dbfbd34dc57829fdbc7d687143c2c (presubmit successful).