pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart - Issue 1383483006: Extract DiagnosticReporter implementation from Compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart

Issue 1383483006: Extract DiagnosticReporter implementation from Compiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes after rebase. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart

diff --git a/pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart b/pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart

index 9a2cbe29423176e09a923f8680d2f1c79c98bf97..55d8789b22a10c40f87960ea2073a479dfd1bf0a 100644

--- a/pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart

+++ b/pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart

@@ -56,7 +56,7 @@ InstanceMirror _convertConstantToInstanceMirror(

} else if (value.isConstructedObject) {

return new Dart2JsConstructedConstantMirror(mirrorSystem, constant, value);

}

- mirrorSystem.compiler.internalError(NO_LOCATION_SPANNABLE,

+ mirrorSystem.compiler.reporter.internalError(NO_LOCATION_SPANNABLE,

"Unexpected constant value $value");

return null;

}