Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tests/compiler/dart2js/message_kind_helper.dart

Issue 1383483006: Extract DiagnosticReporter implementation from Compiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fixes after rebase. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/js_spec_string_test.dart ('k') | tests/compiler/dart2js/metadata_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/message_kind_helper.dart
diff --git a/tests/compiler/dart2js/message_kind_helper.dart b/tests/compiler/dart2js/message_kind_helper.dart
index 12089cfcb91c7005ef602416cf4d52c6d70e7aa8..9d60632dd3a5bc82b4cb7f5b70f883e279aedb72 100644
--- a/tests/compiler/dart2js/message_kind_helper.dart
+++ b/tests/compiler/dart2js/message_kind_helper.dart
@@ -114,7 +114,7 @@ Future<Compiler> check(MessageTemplate template, Compiler cachedCompiler) {
}
}
Expect.isTrue(messageFound, '"$pattern" does not match any in $messages');
- Expect.isFalse(compiler.hasCrashed);
+ Expect.isFalse(compiler.reporter.hasCrashed);
if (!unexpectedMessages.isEmpty) {
for (String message in unexpectedMessages) {
print("Unexpected message: $message");
@@ -129,13 +129,13 @@ Future<Compiler> check(MessageTemplate template, Compiler cachedCompiler) {
bool pendingStuff = false;
for (var e in compiler.resolver.pendingClassesToBePostProcessed) {
pendingStuff = true;
- compiler.reportInfo(
+ compiler.reporter.reportInfo(
e, MessageKind.GENERIC,
{'text': 'Pending class to be post-processed.'});
}
for (var e in compiler.resolver.pendingClassesToBeResolved) {
pendingStuff = true;
- compiler.reportInfo(
+ compiler.reporter.reportInfo(
e, MessageKind.GENERIC,
{'text': 'Pending class to be resolved.'});
}
« no previous file with comments | « tests/compiler/dart2js/js_spec_string_test.dart ('k') | tests/compiler/dart2js/metadata_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698