Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: tests/compiler/dart2js/metadata_test.dart

Issue 1383483006: Extract DiagnosticReporter implementation from Compiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fixes after rebase. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/message_kind_helper.dart ('k') | tests/compiler/dart2js/parser_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/metadata_test.dart
diff --git a/tests/compiler/dart2js/metadata_test.dart b/tests/compiler/dart2js/metadata_test.dart
index f17ac062639fcdf3297415fb082750d3c6f96b64..0f1e9fd76b80b33aa8ae3fe75d03f9af8d2f1c73 100644
--- a/tests/compiler/dart2js/metadata_test.dart
+++ b/tests/compiler/dart2js/metadata_test.dart
@@ -9,9 +9,14 @@ import 'package:expect/expect.dart';
import 'compiler_helper.dart';
import 'package:compiler/src/parser/partial_elements.dart' show
PartialMetadataAnnotation;
-
-void checkPosition(Spannable spannable, Node node, String source, compiler) {
- SourceSpan span = compiler.spanFromSpannable(spannable);
+import 'package:compiler/src/diagnostics/diagnostic_listener.dart' show
+ DiagnosticReporter;
+
+void checkPosition(Spannable spannable,
+ Node node,
+ String source,
+ DiagnosticReporter reporter) {
+ SourceSpan span = reporter.spanFromSpannable(spannable);
Expect.isTrue(span.begin < span.end,
'begin = ${span.begin}; end = ${span.end}');
Expect.isTrue(span.end < source.length,
@@ -41,7 +46,8 @@ void checkAnnotation(String name, String declaration,
compiler.constants.getConstantValue(annotation.constant);
Expect.stringEquals('xyz', value.primitiveValue.slowToString());
- checkPosition(annotation, annotation.cachedNode, source1, compiler);
+ checkPosition(
+ annotation, annotation.cachedNode, source1, compiler.reporter);
});
// Ensure that each repeated annotation has a unique instance of
@@ -69,8 +75,10 @@ void checkAnnotation(String name, String declaration,
Expect.stringEquals('xyz', value1.primitiveValue.slowToString());
Expect.stringEquals('xyz', value2.primitiveValue.slowToString());
- checkPosition(annotation1, annotation1.cachedNode, source2, compiler);
- checkPosition(annotation2, annotation2.cachedNode, source2, compiler);
+ checkPosition(
+ annotation1, annotation1.cachedNode, source2, compiler.reporter);
+ checkPosition(
+ annotation2, annotation2.cachedNode, source2, compiler.reporter);
});
if (isTopLevelOnly) return;
@@ -97,7 +105,8 @@ void checkAnnotation(String name, String declaration,
compiler.constants.getConstantValue(annotation.constant);
Expect.stringEquals('xyz', value.primitiveValue.slowToString());
- checkPosition(annotation, annotation.cachedNode, source3, compiler);
+ checkPosition(
+ annotation, annotation.cachedNode, source3, compiler.reporter);
});
// Ensure that each repeated annotation has a unique instance of
@@ -131,8 +140,10 @@ void checkAnnotation(String name, String declaration,
Expect.stringEquals('xyz', value1.primitiveValue.slowToString());
Expect.stringEquals('xyz', value2.primitiveValue.slowToString());
- checkPosition(annotation1, annotation1.cachedNode, source4, compiler);
- checkPosition(annotation1, annotation2.cachedNode, source4, compiler);
+ checkPosition(
+ annotation1, annotation1.cachedNode, source4, compiler.reporter);
+ checkPosition(
+ annotation1, annotation2.cachedNode, source4, compiler.reporter);
});
}
@@ -179,7 +190,8 @@ void testLibraryTags() {
compiler.constants.getConstantValue(annotation.constant);
Expect.stringEquals('xyz', value.primitiveValue.slowToString());
- checkPosition(annotation, annotation.cachedNode, source, compiler);
+ checkPosition(
+ annotation, annotation.cachedNode, source, compiler.reporter);
}));
}
« no previous file with comments | « tests/compiler/dart2js/message_kind_helper.dart ('k') | tests/compiler/dart2js/parser_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698