pkg/compiler/lib/src/scanner/scanner_task.dart - Issue 1383483006: Extract DiagnosticReporter implementation from Compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/scanner/scanner_task.dart

Issue 1383483006: Extract DiagnosticReporter implementation from Compiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes after rebase. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/scanner/scanner_task.dart

diff --git a/pkg/compiler/lib/src/scanner/scanner_task.dart b/pkg/compiler/lib/src/scanner/scanner_task.dart

index cc13bb52eaca335d630a12fc222488c751802e5a..17b3dbc2407b11a5b65030a23087345e74859dbc 100644

--- a/pkg/compiler/lib/src/scanner/scanner_task.dart

+++ b/pkg/compiler/lib/src/scanner/scanner_task.dart

@@ -30,9 +30,9 @@ class ScannerTask extends CompilerTask {

String canonicalUri = library.canonicalUri.toString();

String resolvedUri = compilationUnit.script.resourceUri.toString();

if (canonicalUri == resolvedUri) {

- compiler.log("Scanning library $canonicalUri");

+ reporter.log("Scanning library $canonicalUri");

} else {

- compiler.log("Scanning library $canonicalUri ($resolvedUri)");

+ reporter.log("Scanning library $canonicalUri ($resolvedUri)");

}

scan(compilationUnit);

}