tests/compiler/dart2js/js_spec_string_test.dart - Issue 1383483006: Extract DiagnosticReporter implementation from Compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/js_spec_string_test.dart

Issue 1383483006: Extract DiagnosticReporter implementation from Compiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes after rebase. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/js_spec_string_test.dart

diff --git a/tests/compiler/dart2js/js_spec_string_test.dart b/tests/compiler/dart2js/js_spec_string_test.dart

index a169bca256183689014af8f81d9712d7e5c77aa0..1481da4bccc6b4338b785e482a4a64e95c64d01d 100644

--- a/tests/compiler/dart2js/js_spec_string_test.dart

+++ b/tests/compiler/dart2js/js_spec_string_test.dart

@@ -14,7 +14,7 @@ import 'package:compiler/src/universe/side_effects.dart'

const OBJECT = 'Object';

const NULL = 'Null';

-class Listener extends DiagnosticListener {

+class Listener extends DiagnosticReporter {

String errorMessage;

internalError(spannable, message) {

errorMessage = message;