pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart - Issue 1383483006: Extract DiagnosticReporter implementation from Compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart

Issue 1383483006: Extract DiagnosticReporter implementation from Compiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes after rebase. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart

diff --git a/pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart b/pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart

index 2d43e7d048c77c29e79b516b29a3ce4abf4ce158..feaf5493ce57abe147b64de16a4830c12ca9042c 100644

--- a/pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart

+++ b/pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart

@@ -126,7 +126,7 @@ class Dart2JsLibraryDependencyMirror implements LibraryDependencySourceMirror {

SourceLocation get location {

return new Dart2JsSourceLocation(

_sourceLibrary._element.entryCompilationUnit.script,

- _sourceLibrary.mirrorSystem.compiler.spanFromNode(_node));

+ _sourceLibrary.mirrorSystem.compiler.reporter.spanFromSpannable(_node));

}

List<CombinatorMirror> get combinators {