pkg/compiler/lib/src/dump_info.dart - Issue 1383483006: Extract DiagnosticReporter implementation from Compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/dump_info.dart

Issue 1383483006: Extract DiagnosticReporter implementation from Compiler. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixes after rebase. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/dump_info.dart

diff --git a/pkg/compiler/lib/src/dump_info.dart b/pkg/compiler/lib/src/dump_info.dart

index 1f1f8bcd243e68a6e672dbb878d6d3bc79b8fd3e..e9d7c05434a32c471e95384baa00dee16c419c52 100644

--- a/pkg/compiler/lib/src/dump_info.dart

+++ b/pkg/compiler/lib/src/dump_info.dart

@@ -560,7 +560,7 @@ class DumpInfoTask extends CompilerTask {

ChunkedConversionSink<Object> sink = encoder.startChunkedConversion(

new StringConversionSink.fromStringSink(buffer));

sink.add(result.toJson());

- compiler.reportInfo(NO_LOCATION_SPANNABLE, MessageKind.GENERIC, {

+ reporter.reportInfo(NO_LOCATION_SPANNABLE, MessageKind.GENERIC, {

'text': "View the dumped .info.json file at "

"https://dart-lang.github.io/dump-info-visualizer"

});