Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1371083003: [presubmit] Enable readability/namespace linter checking. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Yang, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[presubmit] Enable readability/namespace linter checking. This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Committed: https://crrev.com/6a769ac1df0e407d5623170a6cc150a99b9f4ea4 Cr-Commit-Position: refs/heads/master@{#31019}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+832 lines, -506 lines) Patch
M include/v8.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/accessors.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/allocation.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/allocation-site-scopes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/api.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arguments.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/assembler-arm.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/codegen-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/constants-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/frames-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/interface-descriptors-arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/lithium-gap-resolver-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/simulator-arm.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/codegen-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/constants-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/decoder-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/decoder-arm64-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/delayed-masm-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/delayed-masm-arm64-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/disasm-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/frames-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/instructions-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/instrument-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/interface-descriptors-arm64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/lithium-gap-resolver-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/simulator-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/utils-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/assert-scope.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ast.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ast-expression-visitor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-expression-visitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-literal-reindexer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-literal-reindexer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ast-value-factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/background-parsing-task.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/base/atomicops.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_arm64_gcc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_arm_gcc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_atomicword_compat.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_mips64_gcc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_mips_gcc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_portable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/base/atomicops_internals_ppc_gcc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/base/atomicops_internals_x86_gcc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_x86_gcc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/atomicops_internals_x86_msvc.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/cpu.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/cpu.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/lazy-instance.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/macros.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/base/once.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/once.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/condition-variable.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/condition-variable.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/elapsed-timer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/mutex.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/mutex.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-aix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-cygwin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-freebsd.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-macos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-openbsd.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-qnx.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-solaris.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/semaphore.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/semaphore.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/time.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/time.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/utils/random-number-generator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/utils/random-number-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/bignum.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/bignum-dtoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/cached-powers.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/char-predicates.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/char-predicates-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/checks.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/codegen.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compilation-cache.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compilation-dependencies.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/c-linkage.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/frame.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/interpreter-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/interpreter-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/verifier.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/context-measure.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/context-measure.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/contexts.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/conversions-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/counters.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/date.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/dateparser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/dateparser-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/debug/debug.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/debug/liveedit.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/disassembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/diy-fp.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/double.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/dtoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/elements.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/elements-kind.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/execution.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/expression-classifier.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/extensions/externalize-string-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/extensions/free-buffer-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/extensions/gc-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/extensions/statistics-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/extensions/trigger-failure-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/fast-dtoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/field-index.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/field-index-inl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/fixed-dtoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/flags.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/frames.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/frames-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/func-name-inferrer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/futex-emulation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/global-handles.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hashmap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap-inl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/incremental-marking-job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/scavenge-job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/scavenge-job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/spaces.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/store-buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/store-buffer-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-alias-analysis.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-bce.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-bch.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-canonicalize.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-check-elimination.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-dce.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-dehoist.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-environment-liveness.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-escape-analysis.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-flow-engine.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-gvn.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-infer-representation.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-infer-types.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-load-elimination.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-mark-deoptimize.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-mark-unreachable.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-osr.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-range-analysis.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-redundant-phi.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-removable-simulates.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-representation-changes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-sce.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-store-elimination.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-types.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-uint32-analysis.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/i18n.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/simulator-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/access-compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/call-optimization.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ic-compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ic-state.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ic/stub-cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/icu_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/identity-map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/interface-descriptors.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/json-parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/json-stringifier.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/layout-descriptor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/layout-descriptor-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libplatform/default-platform.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/libplatform/task-queue.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libplatform/task-queue.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/libplatform/worker-thread.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libplatform/worker-thread.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/list.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/list-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lithium.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lithium-allocator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lithium-allocator-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lithium-codegen.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lithium-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/log.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/log-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/log-utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lookup.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/lookup-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/macro-assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/constants-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/frames-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-gap-resolver-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/simulator-mips.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/codegen-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/constants-mips64.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/frames-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/lithium-gap-resolver-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/lithium-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/simulator-mips64.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/modules.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/optimizing-compile-dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/codegen-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/constants-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/frames-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/lithium-gap-resolver-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/lithium-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/simulator-ppc.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/preparse-data.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/preparse-data-format.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/preparser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/preparser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/prettyprinter.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/allocation-tracker.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/circular-queue.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/circular-queue-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/cpu-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/cpu-profiler-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/heap-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/profile-generator.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/profile-generator-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/sampler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/unbound-queue.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/profiler/unbound-queue-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/property.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/property-details.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/bytecodes-irregexp.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/regexp/ia32/regexp-macro-assembler-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/interpreter-irregexp.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/jsregexp-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/mips/regexp-macro-assembler-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp/regexp-macro-assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/regexp-macro-assembler-tracer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/regexp-stack.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/x64/regexp-macro-assembler-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/x87/regexp-macro-assembler-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/rewriter.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-atomics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-futex.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/safepoint-table.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/scanner.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/scanner-character-streams.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/scopeinfo.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/scopes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/small-pointer-list.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/natives.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/serialize.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/snapshot.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/snapshot-source-sink.h View 1 chunk +1 line, -1 line 0 comments Download
M src/splay-tree.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/splay-tree-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/string-builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/string-search.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/string-stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/strings-storage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/strtod.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/third_party/fdlibm/fdlibm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/token.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/transitions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/transitions-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/type-feedback-vector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-info.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/types.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/types-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/typing.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/typing-asm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/typing-asm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/typing-reset.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/typing-reset.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/unique.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/v8.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/v8memory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/v8threads.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/variables.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/vector.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/version.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/vm-state.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/vm-state-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/frames-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-gap-resolver-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/simulator-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/code-stubs-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/codegen-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/frames-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/lithium-gap-resolver-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/simulator-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/zone-allocator.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/c-signature.h View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/expression-type-collector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/expression-type-collector.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/gay-fixed.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/gay-precision.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/gay-shortest.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/heap-tester.h View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/print-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/profiler-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-array-list.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-asm-validator.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-identity-map.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-microtask-delivery.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-typing-reset.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-unscopables-hidden-prototype.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/trace-extension.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/types-fuzz.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/node-matchers-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/unittests/runtime/runtime-interpreter-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/presubmit.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/shell-utils.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
Mostly mass-replace, just a few manual edits, all mechanical. https://codereview.chromium.org/1371083003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/1371083003/diff/1/src/objects.h#newcode10629 src/objects.h:10629: ...
5 years, 2 months ago (2015-09-29 12:28:12 UTC) #1
Benedikt Meurer
Wow, massive change :-) LGTM
5 years, 2 months ago (2015-09-29 14:45:46 UTC) #2
ulan
debug and regexp changes lgtm
5 years, 2 months ago (2015-09-29 16:38:50 UTC) #4
Toon Verwaest
snapshot lgtm
5 years, 2 months ago (2015-09-30 12:27:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371083003/20001
5 years, 2 months ago (2015-09-30 13:37:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 13:47:07 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 13:47:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a769ac1df0e407d5623170a6cc150a99b9f4ea4
Cr-Commit-Position: refs/heads/master@{#31019}

Powered by Google App Engine
This is Rietveld 408576698