Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/presubmit.py

Issue 1371083003: [presubmit] Enable readability/namespace linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/runtime/runtime-interpreter-unittest.cc ('k') | tools/shell-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index 338c7085485bfd827557e0f83c16788e3460d78c..5029450ee74e84bdd4ebffc0bb91d17cf7c18637 100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -50,7 +50,6 @@ from subprocess import PIPE
# build/include_what_you_use: Started giving false positives for variables
# named "string" and "map" assuming that you needed to include STL headers.
# TODO(bmeurer): Fix and re-enable readability/check
-# TODO(mstarzinger): Fix and re-enable readability/namespace
LINT_RULES = """
-build/header_guard
@@ -59,7 +58,6 @@ LINT_RULES = """
-build/namespaces
-readability/check
-readability/inheritance
--readability/namespace
-readability/nolint
+readability/streams
-runtime/references
« no previous file with comments | « test/unittests/runtime/runtime-interpreter-unittest.cc ('k') | tools/shell-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698