Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed)

Created:
5 years, 3 months ago by ki.stfu
Modified:
5 years, 3 months ago
Reviewers:
stanisc, Nicolas Zea, pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Pass std::string as const reference from sync/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=pavely@chromium.org,stanisc@chromium.org,zea@chromium.org Committed: https://crrev.com/063ac230c8e9dfeb19d85afcb9d240a0008763aa Cr-Commit-Position: refs/heads/master@{#350126}

Patch Set 1 #

Patch Set 2 : Fix chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc #

Patch Set 3 : Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -103 lines) Patch
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/public/sync_manager_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h View 1 chunk +2 lines, -1 line 0 comments Download
M sync/internal_api/sync_encryption_handler_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sync/test/engine/mock_connection_manager.h View 5 chunks +58 lines, -49 lines 0 comments Download
M sync/test/engine/mock_connection_manager.cc View 12 chunks +47 lines, -38 lines 0 comments Download
M sync/test/engine/test_id_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/test/fake_server/bookmark_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/bookmark_entity.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/fake_server_entity.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/fake_server/fake_server_entity.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/cryptographer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/util/cryptographer.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
ki.stfu
5 years, 3 months ago (2015-09-20 20:16:16 UTC) #1
pavely
lgtm
5 years, 3 months ago (2015-09-21 18:13:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348313003/1
5 years, 3 months ago (2015-09-21 21:14:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/62828) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-21 21:31:51 UTC) #6
ki.stfu
On 2015/09/21 18:13:06, pavely wrote: > lgtm pavely@: Please review PS2.
5 years, 3 months ago (2015-09-21 21:43:57 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348313003/20001
5 years, 3 months ago (2015-09-21 21:45:41 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348313003/40001
5 years, 3 months ago (2015-09-21 21:50:27 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-21 22:31:41 UTC) #13
pavely
lgtm
5 years, 3 months ago (2015-09-22 05:09:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348313003/40001
5 years, 3 months ago (2015-09-22 07:50:48 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-22 07:55:31 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 07:56:23 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/063ac230c8e9dfeb19d85afcb9d240a0008763aa
Cr-Commit-Position: refs/heads/master@{#350126}

Powered by Google App Engine
This is Rietveld 408576698