Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: sync/test/fake_server/bookmark_entity.h

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/test/engine/test_id_factory.h ('k') | sync/test/fake_server/bookmark_entity.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/fake_server/bookmark_entity.h
diff --git a/sync/test/fake_server/bookmark_entity.h b/sync/test/fake_server/bookmark_entity.h
index 5f4528d4ac412797d723f53a889cdf31c27068af..c146f86b80c268867e042e3b3631ab3f4e7718a4 100644
--- a/sync/test/fake_server/bookmark_entity.h
+++ b/sync/test/fake_server/bookmark_entity.h
@@ -49,7 +49,7 @@ class BookmarkEntity : public FakeServerEntity {
int64 creation_time,
int64 last_modified_time);
- void SetParentId(std::string parent_id);
+ void SetParentId(const std::string& parent_id);
// FakeServerEntity implementation.
std::string GetParentId() const override;
« no previous file with comments | « sync/test/engine/test_id_factory.h ('k') | sync/test/fake_server/bookmark_entity.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698