Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: sync/test/fake_server/bookmark_entity.cc

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/test/fake_server/bookmark_entity.h ('k') | sync/test/fake_server/fake_server_entity.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/fake_server/bookmark_entity.cc
diff --git a/sync/test/fake_server/bookmark_entity.cc b/sync/test/fake_server/bookmark_entity.cc
index 7f0b1cb6e10910bb44b670c39b4a031631938a1b..0c7e53736e5860f74547ace754fbc3ed8a1c35d5 100644
--- a/sync/test/fake_server/bookmark_entity.cc
+++ b/sync/test/fake_server/bookmark_entity.cc
@@ -94,7 +94,7 @@ BookmarkEntity::BookmarkEntity(
SetSpecifics(specifics);
}
-void BookmarkEntity::SetParentId(string parent_id) {
+void BookmarkEntity::SetParentId(const string& parent_id) {
parent_id_ = parent_id;
}
« no previous file with comments | « sync/test/fake_server/bookmark_entity.h ('k') | sync/test/fake_server/fake_server_entity.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698