sync/test/fake_server/fake_server_entity.h - Issue 1348313003: Cleanup: Pass std::string as const reference from sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/test/fake_server/fake_server_entity.h

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/test/fake_server/fake_server_entity.h

diff --git a/sync/test/fake_server/fake_server_entity.h b/sync/test/fake_server/fake_server_entity.h

index ed120969b5ad0730161b7c07f1f7120944cc0d0f..a1316d189ec8cb70162fa91f8dda7d79125e5c11 100644

--- a/sync/test/fake_server/fake_server_entity.h

+++ b/sync/test/fake_server/fake_server_entity.h

@@ -35,7 +35,7 @@ class FakeServerEntity {

int64 GetVersion() const;

void SetVersion(int64 version);

const std::string& GetName() const;

- void SetName(std::string name);

+ void SetName(const std::string& name);

// Replaces |specifics_| with |updated_specifics|. This method is meant to be

// used to mimic a client commit.

« no previous file with comments | « sync/test/fake_server/bookmark_entity.cc ('k') | sync/test/fake_server/fake_server_entity.cc » ('j') | no next file with comments »