sync/internal_api/public/sync_manager_factory.h - Issue 1348313003: Cleanup: Pass std::string as const reference from sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/sync_manager_factory.h

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc ('k') | sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/sync_manager_factory.h

diff --git a/sync/internal_api/public/sync_manager_factory.h b/sync/internal_api/public/sync_manager_factory.h

index a121c8bf1f720b16c13d4dfd6572dbfca39c33bf..e38afb100d14dc449a79e55e669593dac181bd19 100644

--- a/sync/internal_api/public/sync_manager_factory.h

+++ b/sync/internal_api/public/sync_manager_factory.h

@@ -26,7 +26,7 @@ class SYNC_EXPORT SyncManagerFactory {

SyncManagerFactory(MANAGER_TYPE type);

virtual ~SyncManagerFactory();

- virtual scoped_ptr<SyncManager> CreateSyncManager(std::string name);

+ virtual scoped_ptr<SyncManager> CreateSyncManager(const std::string& name);

private:

MANAGER_TYPE type_;