sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc - Issue 1348313003: Cleanup: Pass std::string as const reference from sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc

diff --git a/sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc b/sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc

index 7c3e643dd5423950ae580f3b3d08d12f59e729ae..ff72bcd3688b943d028cce2e4562e002ebf925aa 100644

--- a/sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc

+++ b/sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc

@@ -17,7 +17,8 @@ SyncManagerFactoryForProfileSyncTest::SyncManagerFactoryForProfileSyncTest(

SyncManagerFactoryForProfileSyncTest::~SyncManagerFactoryForProfileSyncTest() {}

scoped_ptr<syncer::SyncManager>

-SyncManagerFactoryForProfileSyncTest::CreateSyncManager(std::string name) {

+SyncManagerFactoryForProfileSyncTest::CreateSyncManager(

+ const std::string& name) {

return scoped_ptr<syncer::SyncManager>(

new SyncManagerForProfileSyncTest(

name,

« no previous file with comments | « sync/internal_api/sync_manager_factory.cc ('k') | sync/test/engine/mock_connection_manager.h » ('j') | no next file with comments »