sync/internal_api/sync_manager_factory.cc - Issue 1348313003: Cleanup: Pass std::string as const reference from sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_manager_factory.cc

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/sync_encryption_handler_impl_unittest.cc ('k') | sync/internal_api/test/sync_manager_factory_for_profile_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/sync_manager_factory.cc

diff --git a/sync/internal_api/sync_manager_factory.cc b/sync/internal_api/sync_manager_factory.cc

index c3f09d32e5b09f3e7eb1cffd3511d804339636d4..288b5dad45f482fe6a66add540671b5bfba9bcc0 100644

--- a/sync/internal_api/sync_manager_factory.cc

+++ b/sync/internal_api/sync_manager_factory.cc

@@ -18,7 +18,7 @@ SyncManagerFactory::~SyncManagerFactory() {

}

scoped_ptr<SyncManager> SyncManagerFactory::CreateSyncManager(

- const std::string name) {

+ const std::string& name) {

switch (type_) {

case NORMAL:

return scoped_ptr<SyncManager>(new SyncManagerImpl(name));