Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7490)

Unified Diff: chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc

Issue 1348313003: Cleanup: Pass std::string as const reference from sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mark |name| argument as unused in FakeSyncManagerFactory::CreateSyncManager Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/internal_api/public/sync_manager_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
diff --git a/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc b/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
index 01a587fb4c9954582d05b40a54d9c9db349c1cd3..4c09eea87d04a137ef42848e83a98becfb949e06 100644
--- a/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
+++ b/chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
@@ -123,7 +123,8 @@ class FakeSyncManagerFactory : public syncer::SyncManagerFactory {
~FakeSyncManagerFactory() override {}
// SyncManagerFactory implementation. Called on the sync thread.
- scoped_ptr<SyncManager> CreateSyncManager(std::string name) override {
+ scoped_ptr<SyncManager> CreateSyncManager(
+ const std::string& /* name */) override {
*fake_manager_ = new FakeSyncManager(initial_sync_ended_types_,
progress_marker_types_,
configure_fail_types_);
« no previous file with comments | « no previous file | sync/internal_api/public/sync_manager_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698