Rename GrGLBinding->GrGLStandard, no longer a bitfield

Rename GrGLBinding->GrGLStandard, no longer a bitfield

BUG=skia:2042
Committed: http://code.google.com/p/skia/source/detail?r=13108

[bsalomon, 2014-01-15 21:27:27]

We used to support alllowing a single GrGLInterface to support multiple
"bindings". This is no longer allowed. GrGLBinding doesn't need to be a bitfield
any longer. I took this opportunity to give it a new name since "binding" makes
even less sense now.

[jvanverth1, 2014-01-15 21:35:03]

Happy to take a look once you address the trybot build failures...

[bsalomon, 2014-01-16 14:21:53]

On 2014/01/15 21:35:03, JimVV wrote:
> Happy to take a look once you address the trybot build failures...

done

[jvanverth1, 2014-01-16 15:56:24]

LGTM. Just one nit, which might be due to the tool.

There is one downside to this change: kDesktop and kES are visually distinct
enough that you can tell the difference between them quickly. kGL and kGLES are
more accurate, but less distinct.

https://codereview.chromium.org/133413003/diff/130001/src/gpu/gl/GrGLContext.cpp
File src/gpu/gl/GrGLContext.cpp (right):

https://codereview.chromium.org/133413003/diff/130001/src/gpu/gl/GrGLContext....
src/gpu/gl/GrGLContext.cpp:53: fStandard = interface->fStandard;
Indent?

[bsalomon, 2014-01-16 16:02:09]

I agree about the names. I couldn't think of anything I liked that didn't seem
inexact but was visually distinct.

https://codereview.chromium.org/133413003/diff/130001/src/gpu/gl/GrGLContext.cpp
File src/gpu/gl/GrGLContext.cpp (right):

https://codereview.chromium.org/133413003/diff/130001/src/gpu/gl/GrGLContext....
src/gpu/gl/GrGLContext.cpp:53: fStandard = interface->fStandard;
On 2014/01/16 15:56:24, JimVV wrote:
> Indent?

? Looks right to me.

[bsalomon, 2014-01-16 16:03:00]

On 2014/01/16 15:56:24, JimVV wrote:
> LGTM. Just one nit, which might be due to the tool.

Just noticed this note about the tool. I think the indentation is correct.

[commit-bot: I haz the power, 2014-01-16 16:18:59]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/133413003/130001

[commit-bot: I haz the power, 2014-01-16 16:35:22]

Change committed as 13108