Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318713003: Make classes and structures in core/layout fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/layout fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201298

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -3 lines) Patch
M Source/core/layout/ClipRect.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/FloatingObjects.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/GapRects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/HitTestCache.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/layout/HitTestLocation.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/HitTestRequest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutAnalyzer.h View 4 chunks +7 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBox.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutFrameSet.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutGeometryMap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutGeometryMapStep.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutState.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutTable.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutTableSection.h View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutTestHelper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutThemeFontProvider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutView.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/MultiColumnFragmentainerGroup.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/layout/OrderIterator.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/layout/PaintInvalidationState.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/PendingSelection.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/PointerEventsHitRules.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/ScrollAlignment.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/SubtreeLayoutScope.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/TextAutosizer.h View 7 chunks +9 lines, -0 lines 0 comments Download
M Source/core/layout/VerticalPositionCache.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/api/LineLayoutItem.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositedSelection.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/layout/compositing/CompositedSelectionBound.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositingInputsUpdater.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositingLayerAssigner.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositingReasonFinder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositingRequirementsUpdater.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/GraphicsLayerTreeBuilder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/compositing/GraphicsLayerUpdater.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/layout/line/AbstractInlineTextBox.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/line/BreakingContextInlineHeaders.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/GlyphOverflow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/InlineBox.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/line/InlineIterator.h View 4 chunks +4 lines, -1 line 0 comments Download
M Source/core/layout/line/LayoutTextInfo.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/LineBoxList.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/LineBreaker.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/LineInfo.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/LineLayoutState.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/LineWidth.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/TrailingObjects.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/line/WordMeasurement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/shapes/PolygonShape.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/shapes/RasterShape.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGInlineText.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourcePaintServer.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/layout/svg/ReferenceFilterBuilder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGLayoutSupport.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGMarkerData.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGResourcesCycleSolver.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGSubpathData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextChunkBuilder.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextFragment.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributes.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutAttributesBuilder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngineBaseline.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngineSpacing.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextMetrics.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/SVGTextQuery.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-08-27 02:03:30 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-08-27 05:53:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318713003/20001
5 years, 3 months ago (2015-08-27 07:53:18 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 09:00:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201298

Powered by Google App Engine
This is Rietveld 408576698