Update rendering classes to use OVERRIDE / FINAL when needed

Update rendering classes to use OVERRIDE / FINAL when needed

Update rendering classes to use OVERRIDE / FINAL when needed. Those are useful for
error checking or performance when the compiler supports it.

R=esprehn, abarth
BUG=333316
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164917

[Inactive, 2014-01-10 20:03:36]

+eseidel

[eseidel, 2014-01-10 20:11:49]

lgtm

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/E...
File Source/core/rendering/EllipsisBox.h (right):

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/E...
Source/core/rendering/EllipsisBox.h:51: int height() const { return m_height; }
Lineboxes no longer have virtual height?

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/R...
File Source/core/rendering/RenderButton.h (right):

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/R...
Source/core/rendering/RenderButton.h:46: virtual void
removeLeftoverAnonymousBlock(RenderBlock*) OVERRIDE { }
I wonder why this exists...

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/R...
Source/core/rendering/RenderButton.h:64: virtual bool hasLineIfEmpty() const
OVERRIDE { return node() && node()->hasTagName(HTMLNames::inputTag); }
We inline waaaay too much in blink.

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/R...
File Source/core/rendering/RenderFileUploadControl.h (right):

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/R...
Source/core/rendering/RenderFileUploadControl.h:56: virtual PositionWithAffinity
positionForPoint(const LayoutPoint&) OVERRIDE;
It's not actually final? :)

[commit-bot: I haz the power, 2014-01-10 20:12:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/129173004/100001

[commit-bot: I haz the power, 2014-01-10 20:12:31]

Failed to apply patch for Source/core/rendering/RenderFullScreen.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/RenderFullScreen.h
  Hunk #2 FAILED at 48.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/rendering/RenderFullScreen.h.rej

Patch:       Source/core/rendering/RenderFullScreen.h
Index: Source/core/rendering/RenderFullScreen.h
diff --git a/Source/core/rendering/RenderFullScreen.h
b/Source/core/rendering/RenderFullScreen.h
index
48c40f4f7fe5db58a4aa74189145c2dcf08486a6..175fe9a3e950652abc6fea8a57f77376443e9f0f
100644
--- a/Source/core/rendering/RenderFullScreen.h
+++ b/Source/core/rendering/RenderFullScreen.h
@@ -34,8 +34,8 @@ class RenderFullScreen FINAL : public RenderFlexibleBox {
 public:
     static RenderFullScreen* createAnonymous(Document*);
 
-    virtual bool isRenderFullScreen() const { return true; }
-    virtual const char* renderName() const { return "RenderFullScreen"; }
+    virtual bool isRenderFullScreen() const OVERRIDE { return true; }
+    virtual const char* renderName() const OVERRIDE { return
"RenderFullScreen"; }
 
     void setPlaceholder(RenderBlock*);
     RenderBlock* placeholder() { return m_placeholder; }
@@ -48,7 +48,7 @@ public:
 private:
     RenderFullScreen();
     virtual bool supportsPartialLayout() const OVERRIDE { return false; }
-    virtual void willBeDestroyed();
+    virtual void willBeDestroyed() OVERRIDE;
 
 protected:
     RenderBlock* m_placeholder;

[Inactive, 2014-01-10 20:29:05]

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/E...
File Source/core/rendering/EllipsisBox.h (right):

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/E...
Source/core/rendering/EllipsisBox.h:51: int height() const { return m_height; }
On 2014/01/10 20:11:50, eseidel wrote:
> Lineboxes no longer have virtual height?

height() is not virtual in LineBox class:
    float height() const { return isHorizontal() ? hasVirtualLogicalHeight() ?
virtualLogicalHeight() : logicalHeight() : logicalWidth(); }

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/R...
File Source/core/rendering/RenderFileUploadControl.h (right):

https://codereview.chromium.org/129173004/diff/100001/Source/core/rendering/R...
Source/core/rendering/RenderFileUploadControl.h:56: virtual PositionWithAffinity
positionForPoint(const LayoutPoint&) OVERRIDE;
On 2014/01/10 20:11:50, eseidel wrote:
> It's not actually final? :)

The class is already marked as FINAL so this is redundant.

[commit-bot: I haz the power, 2014-01-10 20:51:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/129173004/220001

[commit-bot: I haz the power, 2014-01-10 21:35:20]

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-10 21:38:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/129173004/220001

[commit-bot: I haz the power, 2014-01-10 22:25:13]

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-10 22:52:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/129173004/220001

[commit-bot: I haz the power, 2014-01-10 23:41:11]

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-10 23:54:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/129173004/220001

[commit-bot: I haz the power, 2014-01-11 01:35:57]

Change committed as 164917