Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: Source/core/rendering/RenderMenuList.h

Issue 129173004: Update rendering classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderMediaControlElements.h ('k') | Source/core/rendering/RenderMeter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderMenuList.h
diff --git a/Source/core/rendering/RenderMenuList.h b/Source/core/rendering/RenderMenuList.h
index 8486471797853f9188758202c4313af471f1f16f..9e14becb5584a044869e122134cc31d186963a6f 100644
--- a/Source/core/rendering/RenderMenuList.h
+++ b/Source/core/rendering/RenderMenuList.h
@@ -54,25 +54,25 @@ public:
private:
HTMLSelectElement* selectElement() const;
- virtual bool isMenuList() const { return true; }
+ virtual bool isMenuList() const OVERRIDE { return true; }
virtual bool isChildAllowed(RenderObject*, RenderStyle*) const OVERRIDE;
- virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0);
- virtual void removeChild(RenderObject*);
- virtual bool createsAnonymousWrapper() const { return true; }
+ virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) OVERRIDE;
+ virtual void removeChild(RenderObject*) OVERRIDE;
+ virtual bool createsAnonymousWrapper() const OVERRIDE { return true; }
- virtual void updateFromElement();
+ virtual void updateFromElement() OVERRIDE;
- virtual LayoutRect controlClipRect(const LayoutPoint&) const;
- virtual bool hasControlClip() const { return true; }
+ virtual LayoutRect controlClipRect(const LayoutPoint&) const OVERRIDE;
+ virtual bool hasControlClip() const OVERRIDE { return true; }
virtual bool canHaveGeneratedChildren() const OVERRIDE { return false; }
- virtual const char* renderName() const { return "RenderMenuList"; }
+ virtual const char* renderName() const OVERRIDE { return "RenderMenuList"; }
virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const OVERRIDE;
virtual void computePreferredLogicalWidths() OVERRIDE;
- virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
+ virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE;
// PopupMenuClient methods
virtual void valueChanged(unsigned listIndex, bool fireOnChange = true) OVERRIDE;
@@ -100,7 +100,7 @@ private:
virtual HostWindow* hostWindow() const OVERRIDE;
virtual PassRefPtr<Scrollbar> createScrollbar(ScrollableArea*, ScrollbarOrientation, ScrollbarControlSize) OVERRIDE;
- virtual bool hasLineIfEmpty() const { return true; }
+ virtual bool hasLineIfEmpty() const OVERRIDE { return true; }
// Flexbox defines baselines differently than regular blocks.
// For backwards compatibility, menulists need to do the regular block behavior.
« no previous file with comments | « Source/core/rendering/RenderMediaControlElements.h ('k') | Source/core/rendering/RenderMeter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698