Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: Source/core/rendering/RenderScrollbar.h

Issue 129173004: Update rendering classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderRubyText.h ('k') | Source/core/rendering/RenderScrollbarPart.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 20 matching lines...) Expand all
31 #include "wtf/HashMap.h" 31 #include "wtf/HashMap.h"
32 32
33 namespace WebCore { 33 namespace WebCore {
34 34
35 class Frame; 35 class Frame;
36 class Node; 36 class Node;
37 class RenderBox; 37 class RenderBox;
38 class RenderScrollbarPart; 38 class RenderScrollbarPart;
39 class RenderStyle; 39 class RenderStyle;
40 40
41 class RenderScrollbar : public Scrollbar { 41 class RenderScrollbar FINAL : public Scrollbar {
42 protected: 42 protected:
43 RenderScrollbar(ScrollableArea*, ScrollbarOrientation, Node*, Frame*); 43 RenderScrollbar(ScrollableArea*, ScrollbarOrientation, Node*, Frame*);
44 44
45 public: 45 public:
46 friend class Scrollbar; 46 friend class Scrollbar;
47 static PassRefPtr<Scrollbar> createCustomScrollbar(ScrollableArea*, Scrollba rOrientation, Node*, Frame* owningFrame = 0); 47 static PassRefPtr<Scrollbar> createCustomScrollbar(ScrollableArea*, Scrollba rOrientation, Node*, Frame* owningFrame = 0);
48 virtual ~RenderScrollbar(); 48 virtual ~RenderScrollbar();
49 49
50 RenderBox* owningRenderer() const; 50 RenderBox* owningRenderer() const;
51 51
52 void paintPart(GraphicsContext*, ScrollbarPart, const IntRect&); 52 void paintPart(GraphicsContext*, ScrollbarPart, const IntRect&);
53 53
54 IntRect buttonRect(ScrollbarPart); 54 IntRect buttonRect(ScrollbarPart);
55 IntRect trackRect(int startLength, int endLength); 55 IntRect trackRect(int startLength, int endLength);
56 IntRect trackPieceRectWithMargins(ScrollbarPart, const IntRect&); 56 IntRect trackPieceRectWithMargins(ScrollbarPart, const IntRect&);
57 57
58 int minimumThumbLength(); 58 int minimumThumbLength();
59 59
60 virtual bool isOverlayScrollbar() const { return false; } 60 virtual bool isOverlayScrollbar() const OVERRIDE { return false; }
61 61
62 private: 62 private:
63 virtual void setParent(Widget*) OVERRIDE; 63 virtual void setParent(Widget*) OVERRIDE;
64 virtual void setEnabled(bool); 64 virtual void setEnabled(bool) OVERRIDE;
65 65
66 virtual void paint(GraphicsContext*, const IntRect& damageRect); 66 virtual void paint(GraphicsContext*, const IntRect& damageRect) OVERRIDE;
67 67
68 virtual void setHoveredPart(ScrollbarPart); 68 virtual void setHoveredPart(ScrollbarPart) OVERRIDE;
69 virtual void setPressedPart(ScrollbarPart); 69 virtual void setPressedPart(ScrollbarPart) OVERRIDE;
70 70
71 virtual void styleChanged(); 71 virtual void styleChanged() OVERRIDE;
72 72
73 virtual bool isCustomScrollbar() const { return true; } 73 virtual bool isCustomScrollbar() const OVERRIDE { return true; }
74 74
75 void updateScrollbarParts(bool destroy = false); 75 void updateScrollbarParts(bool destroy = false);
76 76
77 PassRefPtr<RenderStyle> getScrollbarPseudoStyle(ScrollbarPart, PseudoId); 77 PassRefPtr<RenderStyle> getScrollbarPseudoStyle(ScrollbarPart, PseudoId);
78 void updateScrollbarPart(ScrollbarPart, bool destroy = false); 78 void updateScrollbarPart(ScrollbarPart, bool destroy = false);
79 79
80 // This Scrollbar(Widget) may outlive the DOM which created it (during tear down), 80 // This Scrollbar(Widget) may outlive the DOM which created it (during tear down),
81 // so we keep a reference to the Node which caused this custom scrollbar cre ation. 81 // so we keep a reference to the Node which caused this custom scrollbar cre ation.
82 // This will not create a reference cycle as the Widget tree is owned by our containing 82 // This will not create a reference cycle as the Widget tree is owned by our containing
83 // FrameView which this Node pointer can in no way keep alive. See webkit bu g 80610. 83 // FrameView which this Node pointer can in no way keep alive. See webkit bu g 80610.
84 RefPtr<Node> m_owner; 84 RefPtr<Node> m_owner;
85 85
86 Frame* m_owningFrame; 86 Frame* m_owningFrame;
87 HashMap<unsigned, RenderScrollbarPart*> m_parts; 87 HashMap<unsigned, RenderScrollbarPart*> m_parts;
88 }; 88 };
89 89
90 DEFINE_TYPE_CASTS(RenderScrollbar, ScrollbarThemeClient, scrollbar, scrollbar->i sCustomScrollbar(), scrollbar.isCustomScrollbar()); 90 DEFINE_TYPE_CASTS(RenderScrollbar, ScrollbarThemeClient, scrollbar, scrollbar->i sCustomScrollbar(), scrollbar.isCustomScrollbar());
91 91
92 } // namespace WebCore 92 } // namespace WebCore
93 93
94 #endif // RenderScrollbar_h 94 #endif // RenderScrollbar_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderRubyText.h ('k') | Source/core/rendering/RenderScrollbarPart.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698