Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: Source/core/rendering/RenderMultiColumnSet.h

Issue 129173004: Update rendering classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderMultiColumnBlock.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 virtual LayoutUnit logicalHeightOfAllFlowThreadContent() const OVERRIDE { re turn m_computedColumnHeight; } 113 virtual LayoutUnit logicalHeightOfAllFlowThreadContent() const OVERRIDE { re turn m_computedColumnHeight; }
114 114
115 // FIXME: For now we return false, but it's likely we will leverage the auto height region code to do column 115 // FIXME: For now we return false, but it's likely we will leverage the auto height region code to do column
116 // balancing. That's why we have an override of this function that is distin ct from RenderRegionSet's override. 116 // balancing. That's why we have an override of this function that is distin ct from RenderRegionSet's override.
117 virtual bool shouldHaveAutoLogicalHeight() const OVERRIDE { return false; } 117 virtual bool shouldHaveAutoLogicalHeight() const OVERRIDE { return false; }
118 118
119 virtual void repaintFlowThreadContent(const LayoutRect& repaintRect) const O VERRIDE; 119 virtual void repaintFlowThreadContent(const LayoutRect& repaintRect) const O VERRIDE;
120 120
121 virtual void collectLayerFragments(LayerFragments&, const LayoutRect& layerB oundingBox, const LayoutRect& dirtyRect) OVERRIDE; 121 virtual void collectLayerFragments(LayerFragments&, const LayoutRect& layerB oundingBox, const LayoutRect& dirtyRect) OVERRIDE;
122 122
123 virtual const char* renderName() const; 123 virtual const char* renderName() const OVERRIDE;
124 124
125 void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset); 125 void paintColumnRules(PaintInfo&, const LayoutPoint& paintOffset);
126 126
127 LayoutUnit columnGap() const; 127 LayoutUnit columnGap() const;
128 LayoutRect columnRectAt(unsigned index) const; 128 LayoutRect columnRectAt(unsigned index) const;
129 unsigned columnCount() const; 129 unsigned columnCount() const;
130 130
131 LayoutRect flowThreadPortionRectAt(unsigned index) const; 131 LayoutRect flowThreadPortionRectAt(unsigned index) const;
132 LayoutRect flowThreadPortionOverflowRect(const LayoutRect& flowThreadPortion , unsigned index, unsigned colCount, LayoutUnit colGap) const; 132 LayoutRect flowThreadPortionOverflowRect(const LayoutRect& flowThreadPortion , unsigned index, unsigned colCount, LayoutUnit colGap) const;
133 133
(...skipping 17 matching lines...) Expand all
151 LayoutUnit m_maximumDistanceBetweenForcedBreaks; 151 LayoutUnit m_maximumDistanceBetweenForcedBreaks;
152 LayoutUnit m_forcedBreakOffset; 152 LayoutUnit m_forcedBreakOffset;
153 }; 153 };
154 154
155 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMultiColumnSet, isRenderMultiColumnSet()); 155 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMultiColumnSet, isRenderMultiColumnSet());
156 156
157 } // namespace WebCore 157 } // namespace WebCore
158 158
159 #endif // RenderMultiColumnSet_h 159 #endif // RenderMultiColumnSet_h
160 160
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderMultiColumnBlock.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698