Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: Source/core/rendering/RenderRubyRun.h

Issue 129173004: Update rendering classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderRubyBase.h ('k') | Source/core/rendering/RenderRubyText.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 public: 45 public:
46 virtual ~RenderRubyRun(); 46 virtual ~RenderRubyRun();
47 47
48 bool hasRubyText() const; 48 bool hasRubyText() const;
49 bool hasRubyBase() const; 49 bool hasRubyBase() const;
50 bool isEmpty() const; 50 bool isEmpty() const;
51 RenderRubyText* rubyText() const; 51 RenderRubyText* rubyText() const;
52 RenderRubyBase* rubyBase() const; 52 RenderRubyBase* rubyBase() const;
53 RenderRubyBase* rubyBaseSafe(); // creates the base if it doesn't already ex ist 53 RenderRubyBase* rubyBaseSafe(); // creates the base if it doesn't already ex ist
54 54
55 virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren, Subt reeLayoutScope&); 55 virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren, Subt reeLayoutScope&) OVERRIDE;
56 virtual void layout(); 56 virtual void layout() OVERRIDE;
57 57
58 virtual bool isChildAllowed(RenderObject*, RenderStyle*) const; 58 virtual bool isChildAllowed(RenderObject*, RenderStyle*) const OVERRIDE;
59 virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0); 59 virtual void addChild(RenderObject* child, RenderObject* beforeChild = 0) OV ERRIDE;
60 virtual void removeChild(RenderObject* child); 60 virtual void removeChild(RenderObject* child) OVERRIDE;
61 61
62 virtual RenderBlock* firstLineBlock() const; 62 virtual RenderBlock* firstLineBlock() const OVERRIDE;
63 virtual void updateFirstLetter(); 63 virtual void updateFirstLetter() OVERRIDE;
64 64
65 void getOverhang(bool firstLine, RenderObject* startRenderer, RenderObject* endRenderer, int& startOverhang, int& endOverhang) const; 65 void getOverhang(bool firstLine, RenderObject* startRenderer, RenderObject* endRenderer, int& startOverhang, int& endOverhang) const;
66 66
67 static RenderRubyRun* staticCreateRubyRun(const RenderObject* parentRuby); 67 static RenderRubyRun* staticCreateRubyRun(const RenderObject* parentRuby);
68 68
69 protected: 69 protected:
70 RenderRubyBase* createRubyBase() const; 70 RenderRubyBase* createRubyBase() const;
71 71
72 private: 72 private:
73 RenderRubyRun(); 73 RenderRubyRun();
74 74
75 virtual bool isRubyRun() const { return true; } 75 virtual bool isRubyRun() const OVERRIDE { return true; }
76 virtual const char* renderName() const { return "RenderRubyRun (anonymous)"; } 76 virtual const char* renderName() const OVERRIDE { return "RenderRubyRun (ano nymous)"; }
77 virtual bool supportsPartialLayout() const OVERRIDE { return false; } 77 virtual bool supportsPartialLayout() const OVERRIDE { return false; }
78 virtual bool createsAnonymousWrapper() const { return true; } 78 virtual bool createsAnonymousWrapper() const OVERRIDE { return true; }
79 virtual void removeLeftoverAnonymousBlock(RenderBlock*) { } 79 virtual void removeLeftoverAnonymousBlock(RenderBlock*) OVERRIDE { }
80 }; 80 };
81 81
82 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderRubyRun, isRubyRun()); 82 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderRubyRun, isRubyRun());
83 83
84 } // namespace WebCore 84 } // namespace WebCore
85 85
86 #endif // RenderRubyRun_h 86 #endif // RenderRubyRun_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderRubyBase.h ('k') | Source/core/rendering/RenderRubyText.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698