Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Issue 1285163003: Move regexp implementation into its own folder. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move regexp implementation into its own folder. Committed: https://crrev.com/67e4b3732aebf6ddd890818d331945bb8e74f03d Cr-Commit-Position: refs/heads/master@{#30144}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -23356 lines) Patch
M BUILD.gn View 16 chunks +27 lines, -27 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D src/arm/regexp-macro-assembler-arm.h View 1 chunk +0 lines, -218 lines 0 comments Download
D src/arm/regexp-macro-assembler-arm.cc View 1 chunk +0 lines, -1199 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D src/arm64/regexp-macro-assembler-arm64.h View 1 chunk +0 lines, -293 lines 0 comments Download
D src/arm64/regexp-macro-assembler-arm64.cc View 1 chunk +0 lines, -1617 lines 0 comments Download
M src/assembler.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
D src/bytecodes-irregexp.h View 1 chunk +0 lines, -81 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D src/ia32/regexp-macro-assembler-ia32.h View 1 chunk +0 lines, -200 lines 0 comments Download
D src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +0 lines, -1230 lines 0 comments Download
D src/interpreter-irregexp.h View 1 chunk +0 lines, -26 lines 0 comments Download
D src/interpreter-irregexp.cc View 1 chunk +0 lines, -610 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/jsregexp.h View 1 chunk +0 lines, -1664 lines 0 comments Download
D src/jsregexp.cc View 1 chunk +0 lines, -6412 lines 0 comments Download
D src/jsregexp-inl.h View 1 chunk +0 lines, -83 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D src/mips/regexp-macro-assembler-mips.h View 1 chunk +0 lines, -225 lines 0 comments Download
D src/mips/regexp-macro-assembler-mips.cc View 1 chunk +0 lines, -1247 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D src/mips64/regexp-macro-assembler-mips64.h View 1 chunk +0 lines, -267 lines 0 comments Download
D src/mips64/regexp-macro-assembler-mips64.cc View 1 chunk +0 lines, -1292 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D src/ppc/regexp-macro-assembler-ppc.h View 1 chunk +0 lines, -213 lines 0 comments Download
D src/ppc/regexp-macro-assembler-ppc.cc View 1 chunk +0 lines, -1254 lines 0 comments Download
D src/regexp-macro-assembler.h View 1 chunk +0 lines, -250 lines 0 comments Download
D src/regexp-macro-assembler.cc View 1 chunk +0 lines, -311 lines 0 comments Download
D src/regexp-macro-assembler-irregexp.h View 1 chunk +0 lines, -130 lines 0 comments Download
D src/regexp-macro-assembler-irregexp.cc View 1 chunk +0 lines, -457 lines 0 comments Download
D src/regexp-macro-assembler-irregexp-inl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D src/regexp-macro-assembler-tracer.h View 1 chunk +0 lines, -84 lines 0 comments Download
D src/regexp-macro-assembler-tracer.cc View 1 chunk +0 lines, -419 lines 0 comments Download
D src/regexp-stack.h View 1 chunk +0 lines, -125 lines 0 comments Download
D src/regexp-stack.cc View 1 chunk +0 lines, -88 lines 0 comments Download
A + src/regexp/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/regexp/arm/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/regexp/arm/regexp-macro-assembler-arm.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + src/regexp/arm/regexp-macro-assembler-arm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/regexp/arm64/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/regexp/arm64/regexp-macro-assembler-arm64.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + src/regexp/arm64/regexp-macro-assembler-arm64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/regexp/bytecodes-irregexp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/regexp/ia32/regexp-macro-assembler-ia32.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + src/regexp/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/regexp/interpreter-irregexp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/regexp/interpreter-irregexp.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/regexp/jsregexp.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/regexp/jsregexp.cc View 1 2 chunks +16 lines, -16 lines 0 comments Download
A + src/regexp/jsregexp-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/regexp/mips/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/regexp/mips/regexp-macro-assembler-mips.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/regexp/mips/regexp-macro-assembler-mips.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/regexp/mips64/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/regexp/mips64/regexp-macro-assembler-mips64.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/regexp/mips64/regexp-macro-assembler-mips64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/regexp/ppc/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/regexp/ppc/regexp-macro-assembler-ppc.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/regexp/ppc/regexp-macro-assembler-ppc.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/regexp/regexp-macro-assembler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/regexp/regexp-macro-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/regexp/regexp-macro-assembler-irregexp.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/regexp/regexp-macro-assembler-irregexp.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/regexp/regexp-macro-assembler-irregexp-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/regexp/regexp-macro-assembler-tracer.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + src/regexp/regexp-macro-assembler-tracer.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + src/regexp/regexp-stack.h View 2 chunks +7 lines, -3 lines 0 comments Download
A + src/regexp/regexp-stack.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/regexp/x64/regexp-macro-assembler-x64.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/regexp/x64/regexp-macro-assembler-x64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
A + src/regexp/x87/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/regexp/x87/regexp-macro-assembler-x87.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + src/regexp/x87/regexp-macro-assembler-x87.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8threads.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D src/x64/regexp-macro-assembler-x64.h View 1 chunk +0 lines, -281 lines 0 comments Download
D src/x64/regexp-macro-assembler-x64.cc View 1 chunk +0 lines, -1362 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D src/x87/regexp-macro-assembler-x87.h View 1 chunk +0 lines, -200 lines 0 comments Download
D src/x87/regexp-macro-assembler-x87.cc View 1 chunk +0 lines, -1229 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M tools/gyp/v8.gyp View 20 chunks +31 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
Please take a look. Thanks!
5 years, 4 months ago (2015-08-12 13:19:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285163003/1
5 years, 4 months ago (2015-08-12 13:20:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 13:50:39 UTC) #6
Michael Lippautz
LGTM https://codereview.chromium.org/1285163003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1285163003/diff/1/src/heap/heap.cc#newcode40 src/heap/heap.cc:40: #include "src/regexp/regexp-macro-assembler.h" // NOLINT nit: alignment off Do ...
5 years, 4 months ago (2015-08-12 14:19:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285163003/20001
5 years, 4 months ago (2015-08-13 06:29:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-13 06:55:28 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 06:55:44 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67e4b3732aebf6ddd890818d331945bb8e74f03d
Cr-Commit-Position: refs/heads/master@{#30144}

Powered by Google App Engine
This is Rietveld 408576698