Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(931)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: src/regexp/arm/OWNERS
Issue
1285163003
:
Move regexp implementation into its own folder. (Closed)
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comment
Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
BUILD.gn
src/arm/code-stubs-arm.cc
src/arm/regexp-macro-assembler-arm.h
src/arm/regexp-macro-assembler-arm.cc
src/arm64/code-stubs-arm64.cc
src/arm64/regexp-macro-assembler-arm64.h
src/arm64/regexp-macro-assembler-arm64.cc
src/assembler.cc
src/ast.h
src/bytecodes-irregexp.h
src/heap/heap.cc
src/ia32/code-stubs-ia32.cc
src/ia32/regexp-macro-assembler-ia32.h
src/ia32/regexp-macro-assembler-ia32.cc
src/interpreter-irregexp.h
src/interpreter-irregexp.cc
src/isolate.h
src/isolate.cc
src/jsregexp.h
src/jsregexp.cc
src/jsregexp-inl.h
src/mips/code-stubs-mips.cc
src/mips/regexp-macro-assembler-mips.h
src/mips/regexp-macro-assembler-mips.cc
src/mips64/code-stubs-mips64.cc
src/mips64/regexp-macro-assembler-mips64.h
src/mips64/regexp-macro-assembler-mips64.cc
src/objects-debug.cc
src/objects-printer.cc
src/ppc/code-stubs-ppc.cc
src/ppc/regexp-macro-assembler-ppc.h
src/ppc/regexp-macro-assembler-ppc.cc
src/regexp-macro-assembler.h
src/regexp-macro-assembler.cc
src/regexp-macro-assembler-irregexp.h
src/regexp-macro-assembler-irregexp.cc
src/regexp-macro-assembler-irregexp-inl.h
src/regexp-macro-assembler-tracer.h
src/regexp-macro-assembler-tracer.cc
src/regexp-stack.h
src/regexp-stack.cc
src/regexp/OWNERS
src/regexp/arm/OWNERS
src/regexp/arm/regexp-macro-assembler-arm.h
src/regexp/arm/regexp-macro-assembler-arm.cc
src/regexp/arm64/OWNERS
src/regexp/arm64/regexp-macro-assembler-arm64.h
src/regexp/arm64/regexp-macro-assembler-arm64.cc
src/regexp/bytecodes-irregexp.h
src/regexp/ia32/regexp-macro-assembler-ia32.h
src/regexp/ia32/regexp-macro-assembler-ia32.cc
src/regexp/interpreter-irregexp.h
src/regexp/interpreter-irregexp.cc
src/regexp/jsregexp.h
src/regexp/jsregexp.cc
src/regexp/jsregexp-inl.h
src/regexp/mips/OWNERS
src/regexp/mips/regexp-macro-assembler-mips.h
src/regexp/mips/regexp-macro-assembler-mips.cc
src/regexp/mips64/OWNERS
src/regexp/mips64/regexp-macro-assembler-mips64.h
src/regexp/mips64/regexp-macro-assembler-mips64.cc
src/regexp/ppc/OWNERS
src/regexp/ppc/regexp-macro-assembler-ppc.h
src/regexp/ppc/regexp-macro-assembler-ppc.cc
src/regexp/regexp-macro-assembler.h
src/regexp/regexp-macro-assembler.cc
src/regexp/regexp-macro-assembler-irregexp.h
src/regexp/regexp-macro-assembler-irregexp.cc
src/regexp/regexp-macro-assembler-irregexp-inl.h
src/regexp/regexp-macro-assembler-tracer.h
src/regexp/regexp-macro-assembler-tracer.cc
src/regexp/regexp-stack.h
src/regexp/regexp-stack.cc
src/regexp/x64/regexp-macro-assembler-x64.h
src/regexp/x64/regexp-macro-assembler-x64.cc
src/regexp/x87/OWNERS
src/regexp/x87/regexp-macro-assembler-x87.h
src/regexp/x87/regexp-macro-assembler-x87.cc
src/runtime/runtime-regexp.cc
src/runtime/runtime-strings.cc
src/v8threads.cc
src/x64/code-stubs-x64.cc
src/x64/regexp-macro-assembler-x64.h
src/x64/regexp-macro-assembler-x64.cc
src/x87/code-stubs-x87.cc
src/x87/regexp-macro-assembler-x87.h
src/x87/regexp-macro-assembler-x87.cc
test/cctest/test-regexp.cc
tools/gyp/v8.gyp
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« src/regexp/OWNERS
('k') |
src/regexp/arm/regexp-macro-assembler-arm.h »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: src/regexp/arm/OWNERS
diff --git a/src/interpreter/OWNERS b/src/regexp/arm/OWNERS
similarity index 100%
copy from src/interpreter/OWNERS
copy to src/regexp/arm/OWNERS
« no previous file with comments
|
« src/regexp/OWNERS
('k') |
src/regexp/arm/regexp-macro-assembler-arm.h »
('j') |
no next file with comments »
Issue 1285163003: Move regexp implementation into its own folder. (Closed)
Created 5 years, 4 months ago by Yang
Modified 5 years, 4 months ago
Reviewers: Michael Lippautz
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Comments: 1
This is Rietveld
408576698