Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1275583002: Pull ICU, rename component build GN variables. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull ICU, rename component build GN variables. This ICU roll only renames component_mode -> is_component_build Update other users of the component_mode string to is_component_build. Rename the declaration to be local to BUILDCONFIG.gn (prefixed with '_'). Removes a bitrotted GN unit test around component handing (it wasn't testing anything useful any more since we removed the built-in component function). Committed: https://crrev.com/2a08763777c45ca4e7a00a846266bbfed31ef673 Cr-Commit-Position: refs/heads/master@{#342204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -32 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +3 lines, -7 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +2 lines, -6 lines 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libpng/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/functions_target_unittest.cc View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
brettw
5 years, 4 months ago (2015-08-05 16:22:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275583002/1
5 years, 4 months ago (2015-08-05 16:23:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/24712)
5 years, 4 months ago (2015-08-05 16:30:17 UTC) #6
brettw
Blocked on https://codereview.chromium.org/1277503003 and WebKit roll
5 years, 4 months ago (2015-08-05 16:43:38 UTC) #7
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-05 18:38:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275583002/1
5 years, 4 months ago (2015-08-06 16:49:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89813)
5 years, 4 months ago (2015-08-06 19:57:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275583002/1
5 years, 4 months ago (2015-08-06 20:01:43 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 21:39:05 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 21:39:53 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a08763777c45ca4e7a00a846266bbfed31ef673
Cr-Commit-Position: refs/heads/master@{#342204}

Powered by Google App Engine
This is Rietveld 408576698