Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: tools/gn/functions_target_unittest.cc

Issue 1275583002: Pull ICU, rename component build GN variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libpng/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions_target_unittest.cc
diff --git a/tools/gn/functions_target_unittest.cc b/tools/gn/functions_target_unittest.cc
index c8f6176c3f5f87fffa79ed682f224d67449a7b20..a7a0de9ac2c63352ec19d0f411b6f10e2ff4e3fb 100644
--- a/tools/gn/functions_target_unittest.cc
+++ b/tools/gn/functions_target_unittest.cc
@@ -26,8 +26,7 @@ TEST(FunctionsTarget, CheckUnused) {
good_input.parsed()->Execute(setup.scope(), &err);
ASSERT_FALSE(err.has_error()) << err.message();
- // Test a source set (this covers everything but component) with an unused
- // variable.
+ // Test a source set with an unused variable.
TestParseInput source_set_input(
"source_set(\"foo\") {\n"
" unused = 5\n"
@@ -36,15 +35,4 @@ TEST(FunctionsTarget, CheckUnused) {
err = Err();
source_set_input.parsed()->Execute(setup.scope(), &err);
ASSERT_TRUE(err.has_error());
-
- // Test a component, which is a different code path.
- TestParseInput component_input(
- "component_mode = \"static_library\"\n"
- "component(\"bar\") {\n"
- " unused = 5\n"
- "}\n");
- ASSERT_FALSE(component_input.has_error());
- err = Err();
- component_input.parsed()->Execute(setup.scope(), &err);
- ASSERT_TRUE(err.has_error()) << err.message();
}
« no previous file with comments | « third_party/libpng/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698