Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1277503003: Convert component_mode -> is_component_build for GN (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Convert component_mode -> is_component_build for GN This is the new name of the variable. R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
brettw
5 years, 4 months ago (2015-08-05 16:43:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277503003/1
5 years, 4 months ago (2015-08-05 16:43:31 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/65138)
5 years, 4 months ago (2015-08-05 18:25:04 UTC) #5
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-05 18:37:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277503003/1
5 years, 4 months ago (2015-08-05 19:14:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/65156)
5 years, 4 months ago (2015-08-05 20:14:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277503003/1
5 years, 4 months ago (2015-08-05 20:51:53 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/65174)
5 years, 4 months ago (2015-08-05 22:25:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277503003/1
5 years, 4 months ago (2015-08-05 22:27:43 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 00:29:04 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200081

Powered by Google App Engine
This is Rietveld 408576698