Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3654)

Unified Diff: build/config/BUILDCONFIG.gn

Issue 1275583002: Pull ICU, rename component build GN variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | build/config/android/config.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILDCONFIG.gn
diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn
index a71b4e2bd1334ea8427d0d8f93f3e36770259288..fc5b392f67c602a7ef1215e5ea6ea8e33916d982 100644
--- a/build/config/BUILDCONFIG.gn
+++ b/build/config/BUILDCONFIG.gn
@@ -604,17 +604,13 @@ if (is_win) {
# COMPONENT SETUP
# ==============================================================================
-# TODO(brettw): Convert component_mode to being a non-exported variable
-# ("_component_mode" instead) once ICU's BUILD.gn file is updated to use
-# is_component_build instead.
if (is_component_build) {
- component_mode = "shared_library"
+ _component_mode = "shared_library"
} else {
- component_mode = "source_set"
+ _component_mode = "source_set"
}
-
template("component") {
- target(component_mode, target_name) {
+ target(_component_mode, target_name) {
forward_variables_from(invoker, "*")
# All shared libraries must have the sanitizer deps to properly link in
« no previous file with comments | « DEPS ('k') | build/config/android/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698