net/third_party/nss/ssl/BUILD.gn - Issue 1275583002: Pull ICU, rename component build GN variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/third_party/nss/ssl/BUILD.gn

Issue 1275583002: Pull ICU, rename component build GN variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/third_party/nss/ssl/BUILD.gn

diff --git a/net/third_party/nss/ssl/BUILD.gn b/net/third_party/nss/ssl/BUILD.gn

index d8f796122b51e8ced044958f21af49e30b0f99e9..ee4449a187b173ad2e3410b822320dcbabf9d67f 100644

--- a/net/third_party/nss/ssl/BUILD.gn

+++ b/net/third_party/nss/ssl/BUILD.gn

@@ -74,11 +74,11 @@ component("libssl") {

"unix_err.c",

"unix_err.h",

]

- if (component_mode == "shared_library") {

+ if (is_component_build) {

ldflags = [ "/DEF:" + rebase_path("exports_win.def", root_build_dir) ]

}

} else if (is_linux) {

- if (component_mode == "shared_library") {

+ if (is_component_build) {

configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]

}

« no previous file with comments | « build/secondary/third_party/nss/BUILD.gn ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »