build/secondary/third_party/nss/BUILD.gn - Issue 1275583002: Pull ICU, rename component build GN variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/third_party/nss/BUILD.gn

Issue 1275583002: Pull ICU, rename component build GN variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/third_party/nss/BUILD.gn

diff --git a/build/secondary/third_party/nss/BUILD.gn b/build/secondary/third_party/nss/BUILD.gn

index 5484c675bf5d2d6746c63cf2e18cef7ea800f9d0..c2648f44ea2d4356430adcd887590e81e42aecd1 100644

--- a/build/secondary/third_party/nss/BUILD.gn

+++ b/build/secondary/third_party/nss/BUILD.gn

@@ -31,7 +31,7 @@ if (is_linux) {

"nspr/lib/libc/include",

]

- if (component_mode != "shared_library") {

+ if (!is_component_build) {

defines += [ "NSPR_STATIC" ]

}

@@ -355,7 +355,7 @@ if (is_linux) {

public_deps += [ ":nssckbi" ]

}

- if (component_mode == "shared_library") {

+ if (is_component_build) {

if (is_mac) {

ldflags = [ "-all_load" ]

} else if (is_win) {

« no previous file with comments | « build/config/android/config.gni ('k') | net/third_party/nss/ssl/BUILD.gn » ('j') | no next file with comments »