third_party/libpng/BUILD.gn - Issue 1275583002: Pull ICU, rename component build GN variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libpng/BUILD.gn

Issue 1275583002: Pull ICU, rename component build GN variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libpng/BUILD.gn

diff --git a/third_party/libpng/BUILD.gn b/third_party/libpng/BUILD.gn

index 056d91d61a9f0424b83bb7d954aff41c718af951..c4e2650c8ae6ab2a1e51d4d2ee9f43cc1126e4f7 100644

--- a/third_party/libpng/BUILD.gn

+++ b/third_party/libpng/BUILD.gn

@@ -16,7 +16,7 @@ config("libpng_config") {

}

if (is_win) {

- if (component_mode == "shared_library") {

+ if (is_component_build) {

defines += [

"PNG_USE_DLL",

"PNG_NO_MODULEDEF",

« no previous file with comments | « net/third_party/nss/ssl/BUILD.gn ('k') | tools/gn/functions_target_unittest.cc » ('j') | no next file with comments »