Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: build/config/android/config.gni

Issue 1275583002: Pull ICU, rename component build GN variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/secondary/third_party/nss/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/config.gni
diff --git a/build/config/android/config.gni b/build/config/android/config.gni
index 32ac6d4c328c9a2d734046ae094625f321175ddc..b0c7e482d2770c406548a9f2f4055d66956657e0 100644
--- a/build/config/android/config.gni
+++ b/build/config/android/config.gni
@@ -165,17 +165,13 @@ if (is_android) {
# Toolchain stuff ------------------------------------------------------------
android_libcpp_root = "$android_ndk_root/sources/cxx-stl/llvm-libc++"
- if (component_mode == "shared_library") {
+ if (is_component_build) {
android_libcpp_library = "c++_shared"
- } else {
- android_libcpp_library = "c++_static"
- }
-
- if (component_mode == "shared_library") {
# By appending .cr, we prevent name collisions with libraries already
# loaded by the Android zygote.
android_product_extension = ".cr.so"
} else {
+ android_libcpp_library = "c++_static"
android_product_extension = ".so"
}
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/secondary/third_party/nss/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698