Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 127163003: Completely removed the Extensions3D class (Take 2) (Closed)

Created:
6 years, 11 months ago by bajones
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, philipj_slow, jbroman, danakj, feature-media-reviews_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, Stephen Chennney, aandrey+blink_chromium.org, pdr., rwlbuis
Visibility:
Public.

Description

Completely removed the Extensions3D class (Take 2) This WebKit-era abstraction serves no useful purpose in the context of blink. Previous CL failed due to lingering Android dependencies. BUG=326382 TBR=kbr@chromium.org, jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164714

Patch Set 1 #

Patch Set 2 : Hopfully fixing the Android build issue #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -827 lines) Patch
M Source/core/html/canvas/ANGLEInstancedArrays.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/ANGLEInstancedArrays.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/canvas/EXTFragDepth.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/html/canvas/EXTTextureFilterAnisotropic.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/canvas/OESElementIndexUint.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/canvas/OESStandardDerivatives.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/canvas/OESTextureFloat.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/canvas/OESTextureFloatLinear.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloat.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/canvas/OESTextureHalfFloatLinear.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/OESVertexArrayObject.cpp View 4 chunks +6 lines, -10 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureATC.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTexturePVRTC.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureS3TC.cpp View 3 chunks +9 lines, -10 lines 0 comments Download
M Source/core/html/canvas/WebGLDebugShaders.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLDepthTexture.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M Source/core/html/canvas/WebGLDrawBuffers.cpp View 6 chunks +13 lines, -15 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 16 chunks +36 lines, -37 lines 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D Source/platform/graphics/Extensions3D.h View 1 chunk +0 lines, -332 lines 0 comments Download
D Source/platform/graphics/Extensions3D.cpp View 1 chunk +0 lines, -247 lines 0 comments Download
M Source/platform/graphics/GraphicsContext3D.h View 6 chunks +4 lines, -13 lines 0 comments Download
M Source/platform/graphics/GraphicsContext3D.cpp View 3 chunks +12 lines, -8 lines 0 comments Download
M Source/platform/graphics/GraphicsTypes3D.h View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M Source/platform/graphics/filters/custom/FECustomFilter.cpp View 4 chunks +15 lines, -21 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 14 chunks +33 lines, -39 lines 0 comments Download
M Source/platform/graphics/gpu/SharedGraphicsContext3D.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 2 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/127163003/40001
6 years, 11 months ago (2014-01-08 20:31:43 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests ...
6 years, 11 months ago (2014-01-08 20:45:21 UTC) #2
bajones
6 years, 11 months ago (2014-01-08 22:45:10 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r164714 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698