Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 1264403002: Test that NotificationEvent.action is set correctly (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@click_actions1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js View 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-action-reflection.html View 1 4 chunks +27 lines, -14 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
johnme
5 years, 4 months ago (2015-08-04 15:57:37 UTC) #2
Peter Beverloo
lgtm
5 years, 4 months ago (2015-08-04 21:03:08 UTC) #3
johnme
jochen@chromium.org: Please review changes in public/web/ & Source/web/. Thanks!
5 years, 4 months ago (2015-08-05 14:00:37 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-05 14:05:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264403002/20001
5 years, 4 months ago (2015-08-07 16:31:48 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:02:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200180

Powered by Google App Engine
This is Rietveld 408576698