Source/web/ServiceWorkerGlobalScopeProxy.h - Issue 1264403002: Test that NotificationEvent.action is set correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 1264403002: Test that NotificationEvent.action is set correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@click_actions1

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-action-reflection.html ('k') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeProxy.h

diff --git a/Source/web/ServiceWorkerGlobalScopeProxy.h b/Source/web/ServiceWorkerGlobalScopeProxy.h

index 30c34b410644b46d4ab9d0eb29e1c08bcfc05153..e1090b480835b3e8f7ca8780d56f8400f2bbfc52 100644

--- a/Source/web/ServiceWorkerGlobalScopeProxy.h

+++ b/Source/web/ServiceWorkerGlobalScopeProxy.h

@@ -76,7 +76,6 @@ public:

void dispatchGeofencingEvent(int, WebGeofencingEventType, const WebString& regionID, const WebCircularGeofencingRegion&) override;

void dispatchInstallEvent(int) override;

void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) override;

- void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&) override;

void dispatchNotificationClickEvent(int, int64_t notificationID, const WebNotificationData&, int actionIndex) override;

void dispatchPushEvent(int, const WebString& data) override;

void dispatchServicePortConnectEvent(WebServicePortConnectEventCallbacks*, const WebURL& targetURL, const WebString& origin, WebServicePortID) override;