Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1262893006: Enable testing NotificationEvent.action (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@click_actions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Total comments: 2

Patch Set 3 : TestRunnerBindings::SimulateWebNotificationClick throws for non int index #

Total comments: 2

Patch Set 4 : Tweak TestRunner gin::Argument handling #

Total comments: 2

Patch Set 5 : Remove check #

Messages

Total messages: 22 (7 generated)
johnme
5 years, 4 months ago (2015-08-04 15:57:23 UTC) #2
Peter Beverloo
https://codereview.chromium.org/1262893006/diff/1/components/test_runner/test_runner.cc File components/test_runner/test_runner.cc (right): https://codereview.chromium.org/1262893006/diff/1/components/test_runner/test_runner.cc#newcode277 components/test_runner/test_runner.cc:277: void SimulateWebNotificationActionClick(const std::string& title, Can we overload methods here? ...
5 years, 4 months ago (2015-08-04 21:08:33 UTC) #3
johnme
Addressed review comments - thanks :) https://codereview.chromium.org/1262893006/diff/1/components/test_runner/test_runner.cc File components/test_runner/test_runner.cc (right): https://codereview.chromium.org/1262893006/diff/1/components/test_runner/test_runner.cc#newcode277 components/test_runner/test_runner.cc:277: void SimulateWebNotificationActionClick(const std::string& ...
5 years, 4 months ago (2015-08-05 13:51:27 UTC) #4
johnme
avi@chromium.org: Please review changes in content/ dpranke@chromium.org: Please review changes in components/test_runner/ TBR=sky for no-op ...
5 years, 4 months ago (2015-08-05 13:56:55 UTC) #6
Avi (use Gerrit)
lgtm
5 years, 4 months ago (2015-08-05 15:07:25 UTC) #7
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1262893006/diff/20001/components/test_runner/test_runner.cc File components/test_runner/test_runner.cc (right): https://codereview.chromium.org/1262893006/diff/20001/components/test_runner/test_runner.cc#newcode1356 components/test_runner/test_runner.cc:1356: args->GetNext(&action_index); what if the 2nd parameter isn't an integer? ...
5 years, 4 months ago (2015-08-05 15:09:16 UTC) #9
johnme
https://codereview.chromium.org/1262893006/diff/20001/components/test_runner/test_runner.cc File components/test_runner/test_runner.cc (right): https://codereview.chromium.org/1262893006/diff/20001/components/test_runner/test_runner.cc#newcode1356 components/test_runner/test_runner.cc:1356: args->GetNext(&action_index); On 2015/08/05 15:09:16, jochen wrote: > what if ...
5 years, 4 months ago (2015-08-06 18:25:47 UTC) #12
Dirk Pranke
(I'll defer to jochen here).
5 years, 4 months ago (2015-08-06 20:43:21 UTC) #13
Peter Beverloo
lgtm I still have a minor personal preference for using a string over an index ...
5 years, 4 months ago (2015-08-07 00:11:28 UTC) #14
johnme
https://codereview.chromium.org/1262893006/diff/40001/components/test_runner/test_runner.cc File components/test_runner/test_runner.cc (right): https://codereview.chromium.org/1262893006/diff/40001/components/test_runner/test_runner.cc#newcode1352 components/test_runner/test_runner.cc:1352: !args->PeekNext().IsEmpty() && !args->GetNext(&action_index)) { On 2015/08/07 00:11:28, Peter Beverloo ...
5 years, 4 months ago (2015-08-07 07:09:54 UTC) #15
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/1262893006/diff/60001/content/shell/browser/layout_test/layout_test_notification_manager.cc File content/shell/browser/layout_test/layout_test_notification_manager.cc (right): https://codereview.chromium.org/1262893006/diff/60001/content/shell/browser/layout_test/layout_test_notification_manager.cc#newcode117 content/shell/browser/layout_test/layout_test_notification_manager.cc:117: CHECK(action_index < 0) << "Simulating action clicks for ...
5 years, 4 months ago (2015-08-07 07:12:33 UTC) #16
johnme
Thanks all! https://codereview.chromium.org/1262893006/diff/60001/content/shell/browser/layout_test/layout_test_notification_manager.cc File content/shell/browser/layout_test/layout_test_notification_manager.cc (right): https://codereview.chromium.org/1262893006/diff/60001/content/shell/browser/layout_test/layout_test_notification_manager.cc#newcode117 content/shell/browser/layout_test/layout_test_notification_manager.cc:117: CHECK(action_index < 0) << "Simulating action clicks ...
5 years, 4 months ago (2015-08-07 14:53:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1262893006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1262893006/80001
5 years, 4 months ago (2015-08-07 14:54:00 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-07 15:33:30 UTC) #21
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 15:34:25 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/96d5012f36918b03a447918523acb17548b49fdb
Cr-Commit-Position: refs/heads/master@{#342358}

Powered by Google App Engine
This is Rietveld 408576698