Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1254423011: Add Notification.maxActions so websites know how many buttons we support (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years, 4 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, peter+watch_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@staticreadonlypeter
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M LayoutTests/http/tests/notifications/notification-properties.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/notifications/Notification.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/notifications/Notification.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M public/platform/modules/notifications/WebNotificationManager.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
johnme
5 years, 4 months ago (2015-07-31 11:57:38 UTC) #2
Peter Beverloo
lgtm https://codereview.chromium.org/1254423011/diff/1/public/platform/modules/notifications/WebNotificationManager.h File public/platform/modules/notifications/WebNotificationManager.h (right): https://codereview.chromium.org/1254423011/diff/1/public/platform/modules/notifications/WebNotificationManager.h#newcode62 public/platform/modules/notifications/WebNotificationManager.h:62: // Returns the maximum number of action buttons ...
5 years, 4 months ago (2015-07-31 12:28:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254423011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254423011/20001
5 years, 4 months ago (2015-07-31 13:35:11 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 15:02:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199838

Powered by Google App Engine
This is Rietveld 408576698