Plumb notification action index for desktop SW notificationclick

Plumb notification action index for desktop SW notificationclick

Spec: https://github.com/whatwg/notifications/pull/48

Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/6tlbJW0NjEA/LF0kPfJx7c0J

Part of a sequence of patches:
- https://codereview.chromium.org/1254423011 (blink)
- https://codereview.chromium.org/1263043002 (blink)
- https://codereview.chromium.org/1263043003 (blink)
- https://codereview.chromium.org/1268813007 (blink)
- https://codereview.chromium.org/1267673003 (chromium)
- https://codereview.chromium.org/1262893005 (blink)
- this patch (chromium)
- https://codereview.chromium.org/1262893006 (chromium)
- https://codereview.chromium.org/1264403002 (blink)

BUG=513671
Committed: https://crrev.com/038cc944e555856f791b2fbc828a5fde93220ef6
Cr-Commit-Position: refs/heads/master@{#342121}

[johnme, 2015-08-04 15:57:02]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2015-08-04 21:11:09]

yay plumbing. lgtm

https://codereview.chromium.org/1269923003/diff/1/content/renderer/service_wo...
File content/renderer/service_worker/service_worker_context_client.cc (right):

https://codereview.chromium.org/1269923003/diff/1/content/renderer/service_wo...
content/renderer/service_worker/service_worker_context_client.cc:724:
action_index);
Doesn't "git cl format" complain about this? IIRC the SW directory requires
that.

[johnme, 2015-08-05 12:05:36]

https://codereview.chromium.org/1269923003/diff/1/content/renderer/service_wo...
File content/renderer/service_worker/service_worker_context_client.cc (right):

https://codereview.chromium.org/1269923003/diff/1/content/renderer/service_wo...
content/renderer/service_worker/service_worker_context_client.cc:724:
action_index);
On 2015/08/04 21:11:09, Peter Beverloo wrote:
> Doesn't "git cl format" complain about this? IIRC the SW directory requires
> that.

Nope. Not sure what you mean by "this" either; if it didn't like this kind of
wrapping, it would have complained about request_id and
persistent_notification_id above.

[johnme, 2015-08-05 12:10:11]

johnme@chromium.org changed reviewers:
+ avi@chromium.org, palmer@chromium.org

[johnme, 2015-08-05 12:10:12]

palmer@chromium.org: Please review
content/common/service_worker/service_worker_messages.h

avi@chromium.org: Please review changes in content/ except
content/browser/notifications/ and
content/common/service_worker/service_worker_messages.h

Thanks!

[Avi (use Gerrit), 2015-08-05 15:08:18]

lgtm

[palmer, 2015-08-05 17:46:06]

IPC security LGTM.

[johnme, 2015-08-06 15:06:32]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2015-08-06 15:06:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1269923003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1269923003/1

[commit-bot: I haz the power, 2015-08-06 16:08:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-06 16:08:40]

Patchset 1 (id:??) landed as
https://crrev.com/038cc944e555856f791b2fbc828a5fde93220ef6
Cr-Commit-Position: refs/heads/master@{#342121}