Issue 1268813007: Fix http/tests/notifications/notification-properties.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1268813007: Fix http/tests/notifications/notification-properties.html (Closed)

Created:
5 years, 4 months ago by johnme

Modified:
5 years, 4 months ago

Reviewers:
Peter Beverloo

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix http/tests/notifications/notification-properties.html https://codereview.chromium.org/1263043003 incorrectly made this test compare a string to a number. This mistake is currently masked by the fact that Notification.maxActions is zero, but will cause errors once https://codereview.chromium.org/1267673003 lands (which increases it). BUG=513671 TBR=peter@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199984

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	LayoutTests/http/tests/notifications/notification-properties.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1262893005 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268813007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268813007/1

5 years, 4 months ago (2015-08-04 15:01:56 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-04 18:00:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199984

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages