Deliver action clicks to page notifications (blink)

Deliver action clicks to page notifications (blink)

WORK IN PROGRESS (likely needs more tests)

BUG=513671

[johnme, 2015-08-07 07:17:00]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2015-08-07 07:25:25]

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
File Source/modules/notifications/Notification.cpp (right):

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
Source/modules/notifications/Notification.cpp:259: // TODO(johnme): Remove this
branch once actions ship.
no need for this TODO (the code is no less obvious than the TODO)

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
Source/modules/notifications/Notification.cpp:265: if (0 <= actionIndex &&
actionIndex < static_cast<int>(m_actions.size()))
if (actionIndex >= 0 && actionIndex < static_cast<>())

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
File Source/modules/notifications/NotificationEvent.cpp (right):

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
Source/modules/notifications/NotificationEvent.cpp:13: : ExtendableEvent(type,
initializer)
Use a delegated constructor w/ observer==nullptr?

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
Source/modules/notifications/NotificationEvent.cpp:17: if
(initializer.hasAction())
You explicitly used "emptyString()" before, now we default to the empty String
constructor. Is this difference observable from Web exposed behaviour?

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
File Source/modules/notifications/PageNotificationEvent.h (right):

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
Source/modules/notifications/PageNotificationEvent.h:40: if
(initializer.hasAction())
--> .cpp

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
File Source/modules/notifications/PageNotificationEvent.idl (right):

https://codereview.chromium.org/1280913002/diff/1/Source/modules/notification...
Source/modules/notifications/PageNotificationEvent.idl:5: //
https://notifications.spec.whatwg.org/#pagenotificationevent
This name is not going to fly as-is (we expose "new Notification()" also in
dedicated and shared workers). Please discuss before landing.

[johnme, 2015-10-20 13:55:10]

Description was changed from

==========
Deliver action clicks to page notifications (blink)

WORK IN PROGRESS (likely needs more tests)

BUG=513671
==========

to

==========
Deliver action clicks to page notifications (blink)

WORK IN PROGRESS (likely needs more tests)

BUG=513671
==========

[johnme, 2015-10-20 13:56:00]

Abandoned, as the spec now only supports action buttons for persistent (SW)
notifications:
https://github.com/whatwg/notifications/pull/48#issuecomment-148123079